Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System routing #2256

Closed
lhenriquegomescamilo opened this issue May 22, 2019 · 6 comments
Closed

System routing #2256

lhenriquegomescamilo opened this issue May 22, 2019 · 6 comments
Labels
needs triage This issue has not been looked into

Comments

@lhenriquegomescamilo
Copy link

lhenriquegomescamilo commented May 22, 2019

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

The simple way to map routers in the NestJS

Expected behavior

The good behavior is a map many routers and the module responsible, example:

@Module({
    routers: [{
         path: '/other', 
         module:  OtherModule, 
         children: [{
              path: 'children', 
              module: ChildrenOtherModule
          }
       }],
    imports: [OtherModule],
    controllers: [AppController],
    providers: [AppService],
})
export class AppModule 
  • When I want to make a request GET in my backend on the specific module, I just use the path: [GET] http://api.com/other and the controller responsible in inside OtherModule will response

What is the motivation/use case for changing the behavior?

  • The Nestjs it's incredible frameworks for NodeJs, it's the best to NodeJS. But my application is booming, routers start to get confused

Environment



Nest version: 6.5.0

 
For Tooling issues:
Node version: 8.12.0
- Platform:  MacOs 10.14.5

Others:
* IntelliJ IDEA 2019.1.2 (Ultimate Edition)  Build #IU-191.7141.44, built on May 7, 2019
@shekohex
Copy link
Contributor

abracadabra 👻, nest-router tada 🎉 !

@lhenriquegomescamilo
Copy link
Author

@shekohex: OMG this is amazing, I'm using in my project to solve the problem of many routers, but I think is a great idea this feature to be inside the framework.

@shekohex
Copy link
Contributor

.... but I think is a great idea this feature to be inside the framework.

we are discussing that here #1438

@kamilmysliwiec
Copy link
Member

@lhenriquegomescamilo we'll provide it soon :)

@lhenriquegomescamilo
Copy link
Author

Thank's everyone! :)

@BrunnerLivio BrunnerLivio added the needs triage This issue has not been looked into label Aug 8, 2019
@lock
Copy link

lock bot commented Nov 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

4 participants