Consider tags, tagged_vlans and object_types as set

Author: dhoffend

changelogs/fragments/fix-1486-list-as-set.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - In addition to `tags`, also consider `tagged_vlans` and `objects_types` as set for updates and comparision

plugins/module_utils/netbox_utils.py

@@ -1491,9 +1491,13 @@ def _update_netbox_object(self, data):
         updated_obj = serialized_nb_obj.copy()
         updated_obj.update(data)
 
-        if serialized_nb_obj.get("tags") and data.get("tags"):
-            serialized_nb_obj["tags"] = set(serialized_nb_obj["tags"])
-            updated_obj["tags"] = set(data["tags"])
+        # these fields are considerd a set and should be in sync with pynetbox
+        # response object
+        list_as_set = ["tags", "tagged_vlans", "object_types"]
+        for k in list_as_set:
+            if serialized_nb_obj.get(k) and data.get(k):
+                serialized_nb_obj[k] = set(serialized_nb_obj[k])
+                updated_obj[k] = set(data[k])
 
         # Ensure idempotency for site on older netbox versions
         version_pre_30 = self._version_check_greater("3.0", self.version)