Tags are hardcoded in the module which doesn't allow for additional tags to be easily added

[prasmussen-wfg]

The module has the "Name" tag hard-coded and doesn't allow additional tags to be defined via the module. There are some workarounds to over-ride (eg. Default_Tags at the provider level) but it's a bit of a pain when it could be fixed at the module level.

Also, volume_tags are missing to tag any EBS volumes that are created.

I recommended adding in a merge for tags under the aws_instance resource that will allow additional tags to be input via a variable such as "tags".
Could do a smiliar thing for volume_tags under the aws_instance resource as well.

eg.

variable "tags" {
description = "A mapping of tags to assign to the resource"
type = map(string)
default = {}
}

tags = merge(
{ "Name" = var.publisher_name },
var.tags
)