Skip to content

Commit f89f4e7

Browse files
committed
refactoring: used ES6 arrow functions
1 parent 08b7393 commit f89f4e7

File tree

2 files changed

+53
-55
lines changed

2 files changed

+53
-55
lines changed

.eslintrc.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ module.exports = {
22
"env": {
33
"browser": true
44
},
5+
"parserOptions": {
6+
"ecmaVersion": 6
7+
},
58
"globals": {
69
"Tracy": true
710
},

src/Tracy/assets/Bar/bar.js

Lines changed: 50 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010
var contentId = document.currentScript.dataset.id;
1111
}
1212

13-
Tracy.getAjaxHeader = function() {
14-
return contentId;
15-
};
13+
Tracy.getAjaxHeader = () => contentId;
1614

1715
Tracy.panelZIndex = Tracy.panelZIndex || 20000;
1816

@@ -30,7 +28,7 @@
3028
Panel.zIndexCounter = 1;
3129

3230
Panel.prototype.init = function() {
33-
var _this = this, elem = this.elem;
31+
var elem = this.elem;
3432

3533
this.init = function() {};
3634
elem.innerHTML = elem.dataset.tracyContent;
@@ -41,43 +39,43 @@
4139

4240
draggable(elem, {
4341
handles: elem.querySelectorAll('h1'),
44-
start: function() {
45-
if (!_this.is(Panel.FLOAT)) {
46-
_this.toFloat();
42+
start: () => {
43+
if (!this.is(Panel.FLOAT)) {
44+
this.toFloat();
4745
}
48-
_this.focus();
46+
this.focus();
4947
}
5048
});
5149

52-
elem.addEventListener('mousedown', function() {
53-
_this.focus();
50+
elem.addEventListener('mousedown', () => {
51+
this.focus();
5452
});
5553

56-
elem.addEventListener('mouseenter', function() {
54+
elem.addEventListener('mouseenter', () => {
5755
clearTimeout(elem.Tracy.displayTimeout);
5856
});
5957

60-
elem.addEventListener('mouseleave', function() {
61-
_this.blur();
58+
elem.addEventListener('mouseleave', () => {
59+
this.blur();
6260
});
6361

64-
elem.addEventListener('mousemove', function(e) {
65-
if (e.buttons && !_this.is(Panel.RESIZED) && (elem.style.width || elem.style.height)) {
62+
elem.addEventListener('mousemove', e => {
63+
if (e.buttons && !this.is(Panel.RESIZED) && (elem.style.width || elem.style.height)) {
6664
elem.classList.add(Panel.RESIZED);
6765
}
6866
});
6967

70-
elem.addEventListener('tracy-toggle', function() {
71-
_this.reposition();
68+
elem.addEventListener('tracy-toggle', () => {
69+
this.reposition();
7270
});
7371

74-
forEach(elem.querySelectorAll('.tracy-icons a'), function(a) {
75-
a.addEventListener('click', function(e) {
72+
forEach(elem.querySelectorAll('.tracy-icons a'), link => {
73+
link.addEventListener('click', e => {
7674
clearTimeout(elem.Tracy.displayTimeout);
77-
if (this.rel === 'close') {
78-
_this.toPeek();
79-
} else if (this.rel === 'window') {
80-
_this.toWindow();
75+
if (link.rel === 'close') {
76+
this.toPeek();
77+
} else if (link.rel === 'window') {
78+
this.toWindow();
8179
}
8280
e.preventDefault();
8381
});
@@ -98,7 +96,7 @@
9896
elem.Tracy.window.focus();
9997
} else {
10098
clearTimeout(elem.Tracy.displayTimeout);
101-
elem.Tracy.displayTimeout = setTimeout(function() {
99+
elem.Tracy.displayTimeout = setTimeout(() => {
102100
elem.classList.add(Panel.FOCUSED);
103101
elem.style.zIndex = Tracy.panelZIndex + Panel.zIndexCounter++;
104102
if (callback) {
@@ -112,7 +110,7 @@
112110
var elem = this.elem;
113111
if (this.is(Panel.PEEK)) {
114112
clearTimeout(elem.Tracy.displayTimeout);
115-
elem.Tracy.displayTimeout = setTimeout(function() {
113+
elem.Tracy.displayTimeout = setTimeout(() => {
116114
elem.classList.remove(Panel.FOCUSED);
117115
}, 50);
118116
}
@@ -158,13 +156,12 @@
158156
doc.title = this.elem.querySelector('h1').textContent;
159157
}
160158

161-
var _this = this;
162-
win.addEventListener('beforeunload', function() {
163-
_this.toPeek();
159+
win.addEventListener('beforeunload', () => {
160+
this.toPeek();
164161
win.close(); // forces closing, can be invoked by F5
165162
});
166163

167-
doc.addEventListener('keyup', function(e) {
164+
doc.addEventListener('keyup', e => {
168165
if (e.keyCode === 27 && !e.shiftKey && !e.altKey && !e.ctrlKey && !e.metaKey) {
169166
win.close();
170167
}
@@ -237,7 +234,7 @@
237234
draggedClass: 'tracy-dragged'
238235
});
239236

240-
this.elem.addEventListener('mousedown', function(e) {
237+
this.elem.addEventListener('mousedown', e => {
241238
e.preventDefault();
242239
});
243240

@@ -246,15 +243,13 @@
246243
};
247244

248245
Bar.prototype.initTabs = function(elem) {
249-
var _this = this;
250-
251-
forEach(elem.getElementsByTagName('a'), function(a) {
252-
a.addEventListener('click', function(e) {
253-
if (this.rel === 'close') {
254-
_this.close();
246+
forEach(elem.getElementsByTagName('a'), link => {
247+
link.addEventListener('click', e => {
248+
if (link.rel === 'close') {
249+
this.close();
255250

256-
} else if (this.rel) {
257-
var panel = Debug.panels[this.rel];
251+
} else if (link.rel) {
252+
var panel = Debug.panels[link.rel];
258253
panel.init();
259254

260255
if (e.shiftKey) {
@@ -266,34 +261,34 @@
266261

267262
} else {
268263
panel.toFloat();
269-
panel.reposition(-Math.round(Math.random() * 100) - 20, (Math.round(Math.random() * 100) + 20) * (_this.isAtTop() ? 1 : -1));
264+
panel.reposition(-Math.round(Math.random() * 100) - 20, (Math.round(Math.random() * 100) + 20) * (this.isAtTop() ? 1 : -1));
270265
}
271266
}
272267
e.preventDefault();
273268
});
274269

275-
a.addEventListener('mouseenter', function(e) {
276-
if (!e.buttons && this.rel && this.rel !== 'close' && !elem.classList.contains('tracy-dragged')) {
277-
var panel = Debug.panels[this.rel], link = this;
278-
panel.focus(function() {
270+
link.addEventListener('mouseenter', e => {
271+
if (!e.buttons && link.rel && link.rel !== 'close' && !elem.classList.contains('tracy-dragged')) {
272+
var panel = Debug.panels[link.rel];
273+
panel.focus(() => {
279274
if (panel.is(Panel.PEEK)) {
280275
panel.init();
281276

282277
var pos = getPosition(panel.elem);
283278
setPosition(panel.elem, {
284279
left: getOffset(link).left + getPosition(link).width + 4 - pos.width,
285-
top: _this.isAtTop()
286-
? getOffset(_this.elem).top + getPosition(_this.elem).height + 4
287-
: getOffset(_this.elem).top - pos.height - 4
280+
top: this.isAtTop()
281+
? getOffset(this.elem).top + getPosition(this.elem).height + 4
282+
: getOffset(this.elem).top - pos.height - 4
288283
});
289284
}
290285
});
291286
}
292287
});
293288

294-
a.addEventListener('mouseleave', function() {
295-
if (this.rel && this.rel !== 'close' && !elem.classList.contains('tracy-dragged')) {
296-
Debug.panels[this.rel].blur();
289+
link.addEventListener('mouseleave', () => {
290+
if (link.rel && link.rel !== 'close' && !elem.classList.contains('tracy-dragged')) {
291+
Debug.panels[link.rel].blur();
297292
}
298293
});
299294
});
@@ -354,7 +349,7 @@
354349
Debug.layer.style.display = 'block';
355350
Debug.bar.init();
356351

357-
forEach(document.querySelectorAll('.tracy-panel'), function(panel) {
352+
forEach(document.querySelectorAll('.tracy-panel'), panel => {
358353
Debug.panels[panel.id] = new Panel(panel.id);
359354
Debug.panels[panel.id].dumps = dumps;
360355
Debug.panels[panel.id].restorePosition();
@@ -365,7 +360,7 @@
365360
};
366361

367362
Debug.loadAjax = function(content, dumps) {
368-
forEach(Debug.layer.querySelectorAll('.tracy-panel.tracy-ajax'), function(panel) {
363+
forEach(Debug.layer.querySelectorAll('.tracy-panel.tracy-ajax'), panel => {
369364
Debug.panels[panel.id].savePosition();
370365
delete Debug.panels[panel.id];
371366
panel.parentNode.removeChild(panel);
@@ -383,7 +378,7 @@
383378
Debug.bar.elem.appendChild(ajaxBar);
384379
Debug.bar.restorePosition();
385380

386-
forEach(document.querySelectorAll('.tracy-panel'), function(panel) {
381+
forEach(document.querySelectorAll('.tracy-panel'), panel => {
387382
if (!Debug.panels[panel.id]) {
388383
Debug.panels[panel.id] = new Panel(panel.id);
389384
Debug.panels[panel.id].dumps = dumps;
@@ -397,7 +392,7 @@
397392
Debug.captureWindow = function() {
398393
var size = getWindowSize();
399394

400-
window.addEventListener('resize', function() {
395+
window.addEventListener('resize', () => {
401396
var newSize = getWindowSize();
402397

403398
Debug.bar.reposition(newSize.width - size.width, newSize.height - size.height);
@@ -409,7 +404,7 @@
409404
size = newSize;
410405
});
411406

412-
window.addEventListener('unload', function() {
407+
window.addEventListener('unload', () => {
413408
Debug.bar.savePosition();
414409
for (var id in Debug.panels) {
415410
Debug.panels[id].savePosition();
@@ -474,7 +469,7 @@
474469
};
475470

476471
function evalScripts(elem) {
477-
forEach(elem.getElementsByTagName('script'), function(script) {
472+
forEach(elem.getElementsByTagName('script'), script => {
478473
if ((!script.hasAttribute('type') || script.type === 'text/javascript' || script.type === 'application/javascript') && !script.tracyEvaluated) {
479474
var dolly = script.ownerDocument.createElement('script');
480475
dolly.textContent = script.textContent;

0 commit comments

Comments
 (0)