Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code in SimpleUndertowConnectionMaker (1.6.x) #2023

Closed
miklish opened this issue Nov 29, 2023 · 1 comment
Closed

Remove unused code in SimpleUndertowConnectionMaker (1.6.x) #2023

miklish opened this issue Nov 29, 2023 · 1 comment

Comments

@miklish
Copy link
Collaborator

miklish commented Nov 29, 2023 •
edited
Loading

PR: #2024

The reuseConnection() method in SimpleConnectionMaker interface (com.networknt.client.simplepool) was removed in PR #1963 (SimpleConnectionPool v2), so there is no longer a need for this method in SimpleUndertowConnectionMaker.
@miklish miklish mentioned this issue Nov 29, 2023
Merged
@stevehu
Copy link
Contributor

stevehu commented Dec 1, 2023

PR is merged.

@stevehu stevehu closed this as completed Dec 1, 2023
This was referenced Jan 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @miklish