fix: file_name was set to empty string in set_file_name method

neurobionics · Feb 26, 2025 · ecdbd77 · ecdbd77
1 parent 4d41ba9
commit ecdbd77
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/opensourceleg/logging/logger.py b/opensourceleg/logging/logger.py
@@ -280,8 +280,8 @@ def set_file_name(self, file_name: Union[str, None]) -> None:
             file_name = file_name.split(".")[0]
 
         self._user_file_name = file_name
-        self._file_path = ""
-        self._csv_path = ""
+        self._file_path = os.path.join(self._log_path, f"{file_name}.log")
+        self._csv_path = os.path.join(self._log_path, f"{file_name}.csv")
 
     def set_file_level(self, level: LogLevel) -> None:
         """

diff --git a/tests/test_logging/test_logging_logger.py b/tests/test_logging/test_logging_logger.py
@@ -152,6 +152,7 @@ def test_repr(test_logger: Logger):
 # Test set file name
 def test_set_file_name_str(test_logger: Logger):
     test_logger.set_file_name("test_file")
+    print(test_logger._file_path)
     assert all([
         test_logger._user_file_name == "test_file",
         test_logger._file_path == f"{CURR_DIR}/test_file.log",

diff --git a/tests/test_time/test_time.py b/tests/test_time/test_time.py
@@ -108,7 +108,7 @@ def test_softrealtimeloop_init(patch_time_time2):
     assert srtl.sum_var == 0.0
     assert srtl.sleep_t_agg == 0.0
     assert srtl.n == 0
-    assert srtl.report is False
+    assert srtl.report is True
 
 
 @pytest.fixture