Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to work with newer Ansible versions #30

Open
s4ke opened this issue Nov 3, 2022 · 6 comments
Open

Adapt to work with newer Ansible versions #30

s4ke opened this issue Nov 3, 2022 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@s4ke
Copy link
Member

s4ke commented Nov 3, 2022

This project currently somewhat has a hard requirement for Ansible 2.8.5 because we have not tested it with anything else.

We should add support for newer Ansible versions. This should be straight forward with the tests we have. It just has to be done.

@s4ke s4ke added enhancement New feature or request help wanted Extra attention is needed labels Nov 3, 2022
@WannaBeGeekster
Copy link

Hello,

I recently found your project and would like to contribute back. I am doing a test right now with updated code that is so far working with the latest version of Ansible (2.16) along with Ubuntu 22.04. Have not tested with updated versions of Postgres (15 and 16). Please let me know proper steps to create a pull request here.

@s4ke
Copy link
Member Author

s4ke commented Jan 1, 2024

Hey @WannaBeGeekster,

This is awesome! Thanks.

Regarding a pull request:

  1. Optional: make sure the tests in the tests/ folder work.
  2. Just create the PR. 🙂 We can do the rest from there.

@WannaBeGeekster
Copy link

Thank you! Will get those updated and ensure they all work properly as well. Quite a few changes to get this working, but I am very close. Could you give me any suggestions on what versions of Operating System and Postgres you would like for me to ensure work still? 20.04 and 22.04 sufficient? 14, 15, and 16? Or should I still be worried about older versions of Postgres? Once I get Ubuntu working I would not mind moving to Alma/Rocky but not sure what would be better, Alma/Rocky or Citus support? I would honestly prefer Citus support. :)

@s4ke
Copy link
Member Author

s4ke commented Jan 4, 2024

Ubuntu 20.04 and 22.04 are fine. And postgres Version: preferrably all that are currently not EOL but the newer ones you liste are obviously more important.

Regarding Citus Support: I fear that this requires a substantial amount of work as it will probably have many more edge cases. But I would be open to a PR.

Adding support for alma/rocky would also be nice.

Your call :-D

@WannaBeGeekster
Copy link

Sounds good. Will definitely do a different pull request for Citus and then a separate one for Alma/Rocky/RHEL.

@WannaBeGeekster
Copy link

Pull request submitted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants