Skip to content

Commit 9b6f8f6

Browse files
committed
kafka-clients-node-metrics: adding missing log statement
1 parent 2558244 commit 9b6f8f6

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

instrumentation/kafka-clients-node-metrics-3.7.0/src/main/java/org/apache/kafka/kafka/clients/consumer/internals/AsyncKafkaConsumer_Instrumentation.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,20 @@
3030

3131
@Weave(originalName = "org.apache.kafka.clients.consumer.internals.AsyncKafkaConsumer")
3232
public abstract class AsyncKafkaConsumer_Instrumentation<K, V> {
33+
34+
private final Metrics metrics = Weaver.callOriginal();
35+
private final String clientId = Weaver.callOriginal();
36+
private final ConsumerMetadata metadata = Weaver.callOriginal();
3337
// It's possible for constructors to be invoked multiple times (e.g. `C() { C("some default") }` ).
3438
// When this happens we don't want to register the metrics reporter multiple times.
3539
@NewField
3640
private boolean metricsReporterInstalled;
3741

38-
private final Metrics metrics = Weaver.callOriginal();
39-
private final ConsumerMetadata metadata = Weaver.callOriginal();
40-
4142
@WeaveAllConstructors
4243
public AsyncKafkaConsumer_Instrumentation() {
4344
if (!metricsReporterInstalled) {
45+
NewRelic.getAgent().getLogger().log(Level.INFO,
46+
"newrelic-kafka-clients-enhancements engaged for consumer {0}", clientId);
4447
metrics.addReporter(new NewRelicMetricsReporter(ClientType.CONSUMER, metadata.fetch().nodes()));
4548
metricsReporterInstalled = true;
4649
}

instrumentation/kafka-clients-node-metrics-3.7.0/src/main/java/org/apache/kafka/kafka/clients/consumer/internals/LegacyKafkaConsumer_Instrumentation.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,20 @@
3030

3131
@Weave(originalName = "org.apache.kafka.clients.consumer.internals.LegacyKafkaConsumer")
3232
public abstract class LegacyKafkaConsumer_Instrumentation<K, V> {
33+
34+
private final Metrics metrics = Weaver.callOriginal();
35+
private final String clientId = Weaver.callOriginal();
36+
private final ConsumerMetadata metadata = Weaver.callOriginal();
3337
// It's possible for constructors to be invoked multiple times (e.g. `C() { C("some default") }` ).
3438
// When this happens we don't want to register the metrics reporter multiple times.
3539
@NewField
3640
private boolean metricsReporterInstalled;
3741

38-
private final Metrics metrics = Weaver.callOriginal();
39-
private final ConsumerMetadata metadata = Weaver.callOriginal();
40-
4142
@WeaveAllConstructors
4243
public LegacyKafkaConsumer_Instrumentation() {
4344
if (!metricsReporterInstalled) {
45+
NewRelic.getAgent().getLogger().log(Level.INFO,
46+
"newrelic-kafka-clients-enhancements engaged for consumer {0}", clientId);
4447
metrics.addReporter(new NewRelicMetricsReporter(ClientType.CONSUMER, metadata.fetch().nodes()));
4548
metricsReporterInstalled = true;
4649
}

0 commit comments

Comments
 (0)