Fixing an error message for the config file.

Author: adrianwebb

src/BaseCommand.ts

@@ -35,7 +35,7 @@ export abstract class BaseCommand implements CommandInterface {
         const requiresProject = (this.constructor as any).requiresProject;
 
         if (requiresProject && !this.projectRoot) {
-            this.error('This command requires to be run within an app project (app.yml not found).', 1);
+            this.error(`This command requires to be run within an app project (${this.cli.name}.yml not found).`, 1);
             return; // TS doesn't know error exits
         }
 

test/unit/core/ConfigLoading.test.ts

@@ -0,0 +1,72 @@
+
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { CLI } from '../../../src/CLI.js';
+import { BaseCommand } from '../../../src/BaseCommand.js';
+import * as ConfigUtils from '../../../src/utils/config.js';
+import pc from 'picocolors';
+import process from 'node:process';
+
+vi.mock('../../../src/utils/config.js');
+
+class TestProjectRequiredCommand extends BaseCommand {
+    static requiresProject = true;
+    async run() { }
+}
+
+describe('Config Loading & Error Messaging', () => {
+    let processExitSpy: any;
+    let consoleLogSpy: any;
+
+    beforeEach(() => {
+        vi.clearAllMocks();
+        processExitSpy = vi.spyOn(process, 'exit').mockImplementation((() => { }) as any);
+        consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => { });
+    });
+
+    afterEach(() => {
+        processExitSpy.mockRestore();
+        consoleLogSpy.mockRestore();
+    });
+
+    it('should propagate command name to config loading', async () => {
+        const cli = new CLI({ commandName: 'astrical' });
+        const command = new TestProjectRequiredCommand(cli);
+
+        // Mock finding root so we don't error out immediately on missing root check logic if we want to proceed,
+        // but wait, we want to verify findProjectRoot call.
+        (ConfigUtils.findProjectRoot as any).mockResolvedValue('/some/path');
+        (ConfigUtils.loadConfig as any).mockResolvedValue({});
+
+        await command.init();
+
+        expect(ConfigUtils.findProjectRoot).toHaveBeenCalledWith('astrical', expect.any(String));
+        expect(ConfigUtils.loadConfig).toHaveBeenCalledWith('astrical', '/some/path');
+    });
+
+    it('should show correct error message when project root is missing for named command', async () => {
+        const cli = new CLI({ commandName: 'astrical' });
+        const command = new TestProjectRequiredCommand(cli);
+
+        (ConfigUtils.findProjectRoot as any).mockResolvedValue(null);
+
+        await command.init();
+
+        expect(consoleLogSpy).toHaveBeenCalledWith(
+            expect.stringContaining(pc.red('✖ This command requires to be run within an app project (astrical.yml not found).'))
+        );
+        expect(process.exit).toHaveBeenCalledWith(1);
+    });
+
+    it('should show default error message when using default name', async () => {
+        const cli = new CLI(); // default 'app'
+        const command = new TestProjectRequiredCommand(cli);
+
+        (ConfigUtils.findProjectRoot as any).mockResolvedValue(null);
+
+        await command.init();
+
+        expect(consoleLogSpy).toHaveBeenCalledWith(
+            expect.stringContaining(pc.red('✖ This command requires to be run within an app project (app.yml not found).'))
+        );
+    });
+});