Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tests in psf_functions_test.py #920

Open
gonzaponte opened this issue Nov 9, 2024 · 0 comments
Open

Review tests in psf_functions_test.py #920

gonzaponte opened this issue Nov 9, 2024 · 0 comments

Comments

@gonzaponte
Copy link
Collaborator

... specifically

  • test_add_empty_sensors_and_normalize_q
  • test_add_empty_sensors_and_normalize_q_file
  • test_hdst_psf_processing

The input data for these tests is not the expected one. We expect hits that correspond to one z-sample and one sensor. Because these tests only check for continuity, we've never noticed they are incorrect.

We should also add more meaningful tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant