perf(DiagnosticService): Don't store data in AppConfig

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Author: marcelklehr

lib/Migration/Version004002001Date20250410110041.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\ContextChat\Migration;
+
+use Closure;
+use OCP\AppFramework\Services\IAppConfig;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version004002001Date20250410110041 extends SimpleMigrationStep {
+
+	public function __construct(
+		private IAppConfig $appConfig,
+	) {
+	}
+
+	/**
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+	 * @param array $options
+	 *
+	 * @return void
+	 */
+	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
+		$this->appConfig->deleteAppValue('background_jobs_diagnostics');
+	}
+}

lib/Service/DiagnosticService.php

@@ -8,7 +8,6 @@
 namespace OCA\ContextChat\Service;
 
 use OCP\AppFramework\Services\IAppConfig;
-use OCP\Exceptions\AppConfigTypeConflictException;
 use OCP\Util;
 use Psr\Log\LoggerInterface;
 
@@ -20,42 +19,13 @@ public function __construct(
 	) {
 	}
 
-	/**
-	 * @return array
-	 * @throws AppConfigTypeConflictException
-	 */
-	public function getBackgroundJobDiagnostics(): array {
-		return $this->appConfig->getAppValueArray('background_jobs_diagnostics', [], true);
-	}
-
-	/**
-	 * @param array $value
-	 * @return void
-	 * @throws AppConfigTypeConflictException
-	 * @throws \JsonException
-	 */
-	private function setBackgroundJobDiagnostics(array $value): void {
-		$this->appConfig->setAppValueArray('background_jobs_diagnostics', $value, true);
-	}
-
 	/**
 	 * @param string $class
 	 * @param int $id
 	 * @return void
 	 */
 	public function sendJobTrigger(string $class, int $id): void {
 		$this->logger->info('CONTEXT_CHAT_DIAGNOSTICS: ' . $class . ' ' . $id . ' triggered');
-		$key = $class . '-' . $id;
-		try {
-			$diagnostics = $this->getBackgroundJobDiagnostics();
-			if (!isset($diagnostics[$key])) {
-				$diagnostics[$key] = [];
-			}
-			$diagnostics[$key] = array_merge(['last_triggered' => time()], $diagnostics[$key]);
-			$this->setBackgroundJobDiagnostics($diagnostics);
-		} catch (\OCP\Exceptions\AppConfigTypeConflictException|\JsonException  $e) {
-			$this->logger->warning('Error during context chat diagnostic jobStart', ['exception' => $e]);
-		}
 	}
 
 	/**
@@ -65,22 +35,6 @@ public function sendJobTrigger(string $class, int $id): void {
 	 */
 	public function sendJobStart(string $class, int $id): void {
 		$this->logger->info('CONTEXT_CHAT_DIAGNOSTICS: ' . $class . ' ' . $id . ' started');
-		$key = $class . '-' . $id;
-		try {
-			$diagnostics = $this->getBackgroundJobDiagnostics();
-			if (!isset($diagnostics[$key])) {
-				$diagnostics[$key] = [];
-			}
-			$diagnostics[$key] = array_merge(['last_started' => time()], $diagnostics[$key]);
-			if (isset($diagnostics[$key]['started_count'])) {
-				$diagnostics[$key]['started_count']++;
-			} else {
-				$diagnostics[$key]['started_count'] = 1;
-			}
-			$this->setBackgroundJobDiagnostics($diagnostics);
-		} catch (\OCP\Exceptions\AppConfigTypeConflictException|\JsonException  $e) {
-			$this->logger->warning('Error during context chat diagnostic jobStart', ['exception' => $e]);
-		}
 	}
 
 	/**
@@ -90,17 +44,6 @@ public function sendJobStart(string $class, int $id): void {
 	 */
 	public function sendJobEnd(string $class, int $id): void {
 		$this->logger->info('CONTEXT_CHAT_DIAGNOSTICS: ' . $class . ' ' . $id . ' ended');
-		$key = $class . '-' . $id;
-		try {
-			$diagnostics = $this->getBackgroundJobDiagnostics();
-			if (!isset($diagnostics[$key])) {
-				$diagnostics[$key] = [];
-			}
-			$diagnostics[$key] = array_merge(['last_ended' => time()], $diagnostics[$key]);
-			$this->setBackgroundJobDiagnostics($diagnostics);
-		} catch (\OCP\Exceptions\AppConfigTypeConflictException|\JsonException  $e) {
-			$this->logger->warning('Error during context chat diagnostic jobStart', ['exception' => $e]);
-		}
 	}
 
 	/**
@@ -110,17 +53,6 @@ public function sendJobEnd(string $class, int $id): void {
 	 */
 	public function sendHeartbeat(string $class, int $id): void {
 		$this->logger->info('CONTEXT_CHAT_DIAGNOSTICS: ' . $class . ' ' . $id . ' running');
-		$key = $class . '-' . $id;
-		try {
-			$diagnostics = $this->getBackgroundJobDiagnostics();
-			if (!isset($diagnostics[$key])) {
-				$diagnostics[$key] = [];
-			}
-			$diagnostics[$key] = array_merge(['last_seen' => time()], $diagnostics[$key]);
-			$this->setBackgroundJobDiagnostics($diagnostics);
-		} catch (\OCP\Exceptions\AppConfigTypeConflictException|\JsonException  $e) {
-			$this->logger->warning('Error during context chat diagnostic heartbeat', ['exception' => $e]);
-		}
 	}
 
 	/**