From 6bf2b45f1b32ddb1e503e6dba89a09bdf02a2d5d Mon Sep 17 00:00:00 2001 From: David Luhmer Date: Sun, 28 Jan 2018 14:41:15 +0100 Subject: [PATCH] fix (hopefully) weird app crash on android 8 --- .../de/luhmer/owncloudnewsreader/helper/FavIconHandler.java | 3 ++- .../owncloudnewsreader/services/DownloadImagesService.java | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java index 37d645d17..fdcc6b052 100644 --- a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java +++ b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java @@ -68,12 +68,13 @@ public static int getResourceIdForRightDefaultFeedIcon(Context context) return R.drawable.default_feed_icon_dark; } - public void PreCacheFavIcon(final Feed feed) { + public void PreCacheFavIcon(final Feed feed) throws IllegalStateException { if(feed.getFaviconUrl() == null) { Log.v(TAG, "No favicon for "+feed.getFeedTitle()); return; } + Log.v(TAG, "Loading image: " + feed.getFaviconUrl()); ImageLoader.getInstance().loadImage(feed.getFaviconUrl(), displayImageOptions, new ImageLoadingListener() { @Override public void onLoadingStarted(String imageUri, View view) { diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java index 24f919e59..02cb0bc4e 100644 --- a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java +++ b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/services/DownloadImagesService.java @@ -130,7 +130,11 @@ protected void onHandleWork(@NonNull Intent intent) { List feedList = dbConn.getListOfFeeds(); FavIconHandler favIconHandler = new FavIconHandler(this); for(Feed feed : feedList) { - favIconHandler.PreCacheFavIcon(feed); + try { + favIconHandler.PreCacheFavIcon(feed); + } catch(IllegalStateException ex) { + Log.e(TAG, ex.getMessage()); + } } } else if(downloadMode.equals(DownloadMode.FAVICONS_AND_PICTURES) || downloadMode.equals(DownloadMode.PICTURES_ONLY)) { long lastId = intent.getLongExtra(LAST_ITEM_ID, 0);