extract methods (avoid too long method "initObservers")

Signed-off-by: Marcel Hibbe <[email protected]>

Author: mahibi

app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt

@@ -238,41 +238,54 @@ class ConversationInfoActivity :
         initObservers()
     }
 
-    @Suppress("Detekt.LongMethod")
     private fun initObservers() {
         initViewStateObserver()
+        initCapabilitiesObersver()
+        initRoomOberserver()
+        initBanActorObserver()
+        initConversationReadOnlyObserver()
+        initClearChatHistoryObserver()
+    }
 
-        viewModel.getCapabilitiesViewState.observe(this) { state ->
-            when (state) {
-                is ConversationInfoViewModel.GetCapabilitiesSuccessState -> {
-                    spreedCapabilities = state.spreedCapabilities
+    private fun initClearChatHistoryObserver() {
+        viewModel.clearChatHistoryViewState.observe(this) { uiState ->
+            when (uiState) {
+                is ConversationInfoViewModel.ClearChatHistoryViewState.None -> {
+                }
 
-                    handleConversation()
+                is ConversationInfoViewModel.ClearChatHistoryViewState.Success -> {
+                    Snackbar.make(
+                        binding.root,
+                        context.getString(R.string.nc_clear_history_success),
+                        Snackbar.LENGTH_LONG
+                    ).show()
                 }
 
-                else -> {}
+                is ConversationInfoViewModel.ClearChatHistoryViewState.Error -> {
+                    Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
+                    Log.e(TAG, "failed to clear chat history", uiState.exception)
+                }
             }
         }
+    }
 
-        viewModel.createRoomViewState.observe(this) { state ->
+    private fun initConversationReadOnlyObserver() {
+        viewModel.getConversationReadOnlyState.observe(this) { state ->
             when (state) {
-                is ConversationInfoViewModel.CreateRoomUIState.Success -> {
-                    state.room.ocs?.data?.token?.let { token ->
-                        val chatIntent = Intent(context, ChatActivity::class.java).apply {
-                            putExtra(KEY_ROOM_TOKEN, token)
-                        }
-                        startActivity(chatIntent)
-                    }
+                is ConversationInfoViewModel.SetConversationReadOnlyViewState.Success -> {
                 }
 
-                is ConversationInfoViewModel.CreateRoomUIState.Error -> {
-                    Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
+                is ConversationInfoViewModel.SetConversationReadOnlyViewState.Error -> {
+                    Snackbar.make(binding.root, R.string.conversation_read_only_failed, Snackbar.LENGTH_LONG).show()
                 }
 
-                else -> {}
+                is ConversationInfoViewModel.SetConversationReadOnlyViewState.None -> {
+                }
             }
         }
+    }
 
+    private fun initBanActorObserver() {
         viewModel.getBanActorState.observe(this) { state ->
             when (state) {
                 is ConversationInfoViewModel.BanActorSuccessState -> {
@@ -286,38 +299,39 @@ class ConversationInfoActivity :
                 else -> {}
             }
         }
+    }
 
-        viewModel.getConversationReadOnlyState.observe(this) { state ->
+    private fun initRoomOberserver() {
+        viewModel.createRoomViewState.observe(this) { state ->
             when (state) {
-                is ConversationInfoViewModel.SetConversationReadOnlyViewState.Success -> {
+                is ConversationInfoViewModel.CreateRoomUIState.Success -> {
+                    state.room.ocs?.data?.token?.let { token ->
+                        val chatIntent = Intent(context, ChatActivity::class.java).apply {
+                            putExtra(KEY_ROOM_TOKEN, token)
+                        }
+                        startActivity(chatIntent)
+                    }
                 }
 
-                is ConversationInfoViewModel.SetConversationReadOnlyViewState.Error -> {
-                    Snackbar.make(binding.root, R.string.conversation_read_only_failed, Snackbar.LENGTH_LONG).show()
+                is ConversationInfoViewModel.CreateRoomUIState.Error -> {
+                    Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
                 }
 
-                is ConversationInfoViewModel.SetConversationReadOnlyViewState.None -> {
-                }
+                else -> {}
             }
         }
+    }
 
-        viewModel.clearChatHistoryViewState.observe(this) { uiState ->
-            when (uiState) {
-                is ConversationInfoViewModel.ClearChatHistoryViewState.None -> {
-                }
+    private fun initCapabilitiesObersver() {
+        viewModel.getCapabilitiesViewState.observe(this) { state ->
+            when (state) {
+                is ConversationInfoViewModel.GetCapabilitiesSuccessState -> {
+                    spreedCapabilities = state.spreedCapabilities
 
-                is ConversationInfoViewModel.ClearChatHistoryViewState.Success -> {
-                    Snackbar.make(
-                        binding.root,
-                        context.getString(R.string.nc_clear_history_success),
-                        Snackbar.LENGTH_LONG
-                    ).show()
+                    handleConversation()
                 }
 
-                is ConversationInfoViewModel.ClearChatHistoryViewState.Error -> {
-                    Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
-                    Log.e(TAG, "failed to clear chat history", uiState.exception)
-                }
+                else -> {}
             }
         }
     }

app/src/test/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModelTest.kt

@@ -1,3 +1,10 @@
+/*
+ * Nextcloud Talk - Android Client
+ *
+ * SPDX-FileCopyrightText: 2025 Marcel Hibbe <[email protected]>
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
 package com.nextcloud.talk.conversationinfo.viewmodel
 
 import org.junit.Test