Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction position and color is wrong and confusing sometimes #4557

Open
nickvergessen opened this issue Dec 19, 2024 · 4 comments
Open

Reaction position and color is wrong and confusing sometimes #4557

nickvergessen opened this issue Dec 19, 2024 · 4 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 🗨️ chat

Comments

@nickvergessen
Copy link
Member

see 4 messages:

  • Own text
  • Own file
  • Foreign text
  • Foreign file
You (Me) like them all Someone (Nickv2) else likes them all
!

Expected

  • Consistent feeling that you liked something (primary color)

Actual

  • File reactions are "outside of the bubble"
  • Own reactions on foreign files have no color background and look exactly like reactions from some one else
  • Own reactions on own messages have a different color then on foreign messages
@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 🗨️ chat labels Dec 19, 2024
@nickvergessen
Copy link
Member Author

@sowjanyakch please have a look

@AndyScherzinger
Copy link
Member

So originally we themed the reaction background for own/others' messages differently, so that should be easy to fix by always theming it with primary color.

File reactions are outside of "the bubble because file-messages do not have a bubble at all at the moment at least on Android. Yet that could come later and wouldn't influence the reaction backgrounds regarding the use of primary color for won reactions.

@nimishavijay
Copy link
Member

True, all messages liked by you should have the primary color like the reaction to NickV2's "Other text" message in You (me) like them all

The position should also stay consistent for all, the reactions for the files are too much sticking to the edge. It should be the same as the reactions for just text.

The position of the reactions for just text can also be adjusted to be a couple pixels farther from the text in the bubble.
The top+bottom padding can be reduced by 1 or 2px and the right+left padding can be increased by 1or 2px to make it look less round.

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 15, 2025

I very strongly advice against the primary color decision, because this logic with a different color on own messages is in place for a reason, see the change in action on sermo:

Before After
Image Image

-> this doesn't work at all, contrast-wise (in any case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 🗨️ chat
Projects
None yet
Development

No branches or pull requests

4 participants