Fix hover hint for namespace functions

Author: bentsherman

src/main/java/nextflow/lsp/ast/ASTNodeStringUtils.java

@@ -29,6 +29,7 @@
 import nextflow.script.dsl.Description;
 import nextflow.script.dsl.DslScope;
 import nextflow.script.dsl.FeatureFlag;
+import nextflow.script.dsl.Namespace;
 import nextflow.script.dsl.Operator;
 import nextflow.script.dsl.OutputDsl;
 import nextflow.script.dsl.ProcessDsl;
@@ -199,11 +200,7 @@ private static String methodToLabel(MethodNode node) {
         if( node instanceof FunctionNode ) {
             builder.append("def ");
         }
-        else if( node.isStatic() ) {
-            builder.append(Types.getName(node.getDeclaringClass()));
-            builder.append('.');
-        }
-        else if( Logger.isDebugEnabled() || !isDslFunction(node) ) {
+        else if( Logger.isDebugEnabled() || (!isDslFunction(node) && !isNamespaceFunction(node)) ) {
             builder.append(Types.getName(node.getDeclaringClass()));
             builder.append(' ');
         }
@@ -222,6 +219,10 @@ private static boolean isDslFunction(MethodNode mn) {
         return mn.getDeclaringClass().implementsInterface(ClassHelper.makeCached(DslScope.class));
     }
 
+    private static boolean isNamespaceFunction(MethodNode mn) {
+        return mn.getDeclaringClass().implementsInterface(ClassHelper.makeCached(Namespace.class));
+    }
+
     private static String methodTypeLabel(MethodNode mn) {
         if( mn instanceof FunctionNode )
             return null;

src/test/groovy/nextflow/lsp/ast/ASTNodeStringUtilsTest.groovy

@@ -23,7 +23,9 @@ import nextflow.script.ast.ProcessNode
 import nextflow.script.ast.WorkflowNode
 import nextflow.script.dsl.FeatureFlagDsl
 import nextflow.script.dsl.ProcessDsl
-import nextflow.script.types.Channel
+import nextflow.script.dsl.ScriptDsl
+import nextflow.script.namespaces.ChannelNamespace
+import nextflow.script.types.shim.Iterable
 import org.codehaus.groovy.ast.ClassHelper
 import org.codehaus.groovy.ast.ClassNode
 import org.codehaus.groovy.ast.Parameter
@@ -40,6 +42,7 @@ class ASTNodeStringUtilsTest extends Specification {
         when:
         def classNode = Mock(ClassNode) {
             isEnum() >> false
+            isResolved() >> true
             getNameWithoutPackage() >> 'Channel'
         }
         then:
@@ -48,6 +51,7 @@ class ASTNodeStringUtilsTest extends Specification {
         when:
         def enumNode = Mock(ClassNode) {
             isEnum() >> true
+            isResolved() >> true
             getNameWithoutPackage() >> 'SequenceTypes'
             getGroovydoc() >> Mock(Groovydoc) {
                 isPresent() >> true
@@ -160,16 +164,36 @@ class ASTNodeStringUtilsTest extends Specification {
 
     def 'should get the label and docs for a built-in function' () {
         when:
-        def node = new ClassNode(Channel.class).getDeclaredMethods('of').first()
+        def node = new ClassNode(ScriptDsl.class).getDeclaredMethods('env').first()
         then:
-        ASTNodeStringUtils.getLabel(node) == 'Channel.of(arg0...: E) -> Channel<E>'
+        ASTNodeStringUtils.getLabel(node) == 'env(arg0: String) -> String'
+        ASTNodeStringUtils.getDocumentation(node) == '''
+            Get the value of an environment variable from the launch environment.
+            '''.stripIndent(true).trim()
+    }
+
+    def 'should get the label and docs for a namespace function' () {
+        when:
+        def node = new ClassNode(ChannelNamespace.class).getDeclaredMethods('of').first()
+        then:
+        ASTNodeStringUtils.getLabel(node) == 'of(arg0...: E) -> Channel<E>'
         ASTNodeStringUtils.getDocumentation(node) == '''
             Create a channel that emits each argument.
 
             [Read more](https://nextflow.io/docs/latest/reference/channel.html#of)
             '''.stripIndent(true).trim()
     }
 
+    def 'should get the label and docs for a method' () {
+        when:
+        def node = new ClassNode(Iterable.class).getDeclaredMethods('collect').first()
+        then:
+        ASTNodeStringUtils.getLabel(node) == 'Iterable collect(arg0: (E) -> R) -> Iterable<R>'
+        ASTNodeStringUtils.getDocumentation(node) == '''
+            Returns a new iterable with each element transformed by the given closure.
+            '''.stripIndent(true).trim()
+    }
+
     def 'should get the label and docs for a process directive' () {
         when:
         def node = new ClassNode(ProcessDsl.DirectiveDsl.class).getDeclaredMethods('executor').first()