Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ext.args to send customized parameters to QUAST modules #748

Open
amizeranschi opened this issue Jan 20, 2025 · 2 comments
Open

Enable ext.args to send customized parameters to QUAST modules #748

amizeranschi opened this issue Jan 20, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@amizeranschi
Copy link
Contributor

Description of feature

Currently there is no way to send customized parameters to QUAST via ext.args. It would be helpful to enable this feature, for example, to allow setting customized --contig-thresholds for report generation.
https://quast.sourceforge.net/docs/manual.html#sec2.3

@amizeranschi amizeranschi added the enhancement New feature or request label Jan 20, 2025
@jfy133
Copy link
Member

jfy133 commented Jan 20, 2025

Generally you can always write your own custom config to override the default ext.args, but Indeed I don't really like giving users too much freedom.

If you have a list of the most important quast parameters that you think most people would want to modify we can add these as dedicated pipeline level parameters

@amizeranschi
Copy link
Contributor Author

Generally you can always write your own custom config to override the default ext.args, but Indeed I don't really like giving users too much freedom.

I'm not sure what you mean here. Given how the current QUAST module looks like right now, I don't see a way that the user could pass custom arguments via ext.args, or any other variable for that matter:
https://github.com/nf-core/mag/blob/dev/modules/local/quast.nf#L19

If you have a list of the most important quast parameters that you think most people would want to modify we can add these as dedicated pipeline level parameters

I'm not familiar with all the parameters and haven't tested QUAST extensively. Right now I was looking at --min-contig, which is 500 by default, and --contig-thresholds, which allows one to customize the contig length thresholds that are used for generating the QC report.

The nf-core/mag pipeline has the --min_contig_size parameter, which selects contigs for binning and is set at 1500 bp by default. It would be useful to have a way of finding out (using QUAST) what is the number of contigs in the assembly (and the total assembled bp) at a minimum length of 1500 bp.

Two other QUAST parameters that could be useful (especially for benchmarking) are -r and --references-list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants