Fix mountPath directory for NAP5 policy documentation #7191
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the path for the volumeMounts shown in the NAP5 compile documentation to use the newest convention, and also adds a missing parameter from the `kubectl cp` example at the end of the page. Issue reported by Fabrizio Fiorucci, as it can cause confusion and possible error for a reader following along and reading the NAP documentation concurrently.
github-actions
bot
added
the
documentation
ADubhlaoich
added
the
needs cherry pick
for more information, see https://pre-commit.ci
✅ Deploy Preview will be available once build job completes!
|
|
Fabrizio has indicated that a user will also need to copy a logging profile bundle as part of this process. The final section of this page is written in a generic enough way to show the user what command to use: they're expected to know what they need to copy. The logging profile bundle isn't actually mentioned anywhere in the existing text, so I'm unsure what modifications would need to be made for it to have the correct context. |
pdabelf5
approved these changes
Jan 23, 2025
jjngx
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7191 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 89 89
Lines 20843 20843
=======================================
Hits 10992 10992
Misses 9394 9394
Partials 457 457 ☔ View full report in Codecov by Sentry. |
AlexFenlon
approved these changes
Jan 23, 2025
nginx-bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Fix mountPath directory for NAP5 policy documentation This commit updates the path for the volumeMounts shown in the NAP5 compile documentation to use the newest convention, and also adds a missing parameter from the `kubectl cp` example at the end of the page. Issue reported by Fabrizio Fiorucci, as it can cause confusion and possible error for a reader following along and reading the NAP documentation concurrently. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jakub Jarosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit updates the path for the volumeMounts shown in the NAP5 compile documentation to use the newest convention, and also adds a missing parameter from the
kubectl cpexample at the end of the page.Issue reported by Fabrizio Fiorucci, as it can cause confusion and possible error for a reader following along and reading the NAP documentation concurrently.
Checklist
Before creating a PR, run through this checklist and mark each as complete.