Merge pull request #780 from 602p/fix-findpeaks

azonenberg · web-flow · commit 148899e23459 · 2023-06-28T19:34:51.000-07:00
Fix memory leak in Filter::FindPeaks
diff --git a/scopehal/Filter.cpp b/scopehal/Filter.cpp
@@ -747,6 +747,8 @@ void Filter::FindPeaks(UniformAnalogWaveform* data, float peak_threshold, vector
 
 		last = value;
 	}
+
+	delete thresh_diff;
 }
 
 /**
@@ -803,6 +805,8 @@ void Filter::FindPeaks(SparseAnalogWaveform* data, float peak_threshold, vector<
 
 		last = value;
 	}
+
+	delete thresh_diff;
 }
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -747,6 +747,8 @@ void Filter::FindPeaks(UniformAnalogWaveform* data, float peak_threshold, vector`
`747`	`747`
`748`	`748`	`last = value;`
`749`	`749`	`}`
	`750`	`+`
	`751`	`+ delete thresh_diff;`
`750`	`752`	`}`
`751`	`753`
`752`	`754`	`/**`
`@@ -803,6 +805,8 @@ void Filter::FindPeaks(SparseAnalogWaveform* data, float peak_threshold, vector<`
`803`	`805`
`804`	`806`	`last = value;`
`805`	`807`	`}`
	`808`	`+`
	`809`	`+ delete thresh_diff;`
`806`	`810`	`}`
`807`	`811`
`808`	`812`	`////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////`