@ngxs/schematics should be added to devDependencies

[xmlking]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior

@ngxs/schematics added to Dependencies

Expected behavior

@ngxs/schematics should be added to devDependencies

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Libs:
- @angular/core version: X.Y.Z
- @ngxs/store version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[markwhitfeld]

Should it reference itself in its dev dependencies?

[xmlking]

i mean something like this
https://github.com/nrwl/nx/blob/master/packages/schematics/src/collection/ng-add/index.ts#L97

[xmlking]

may be we can change the type here
https://github.com/ngxs/schematics/blob/master/src/utils/common/lib.config.ts#L44

[markwhitfeld]

Yes that makes sense

[kyusupov33]

@eranshmil @markwhitfeld your solution doesn't solve that problem, because we need to send PR in angular-cli with change on this file: https://github.com/angular/angular-cli/blob/master/packages/angular/cli/tasks/npm-install.ts

As you can see, they set true in save property by default. In our case, we need to improve it and make flag that will understand where package should added.

[kyusupov33]

angular/angular-cli#13237

[eranshmil]

@kyusupov33 Thanks for the heads up, I also commented there.

[splincode]

@kyusupov33 the author of this package, it is strange that he was expelled

[markwhitfeld]

@splincode no idea how that happened.
Sorry @kyusupov33, I have added you back as a collaborator.

[kyusupov33]

@markwhitfeld thanks :)