Revert "Update net analyzers to 10.0 (#101)" (#103)

* Initial plan

* Revert commit fb643b0: Revert analyzer versions and nuget configuration changes

Co-authored-by: jryckman <4111629+jryckman@users.noreply.github.com>

* Remove accidentally committed build artifacts and add .objs to gitignore

Co-authored-by: jryckman <4111629+jryckman@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jryckman <4111629+jryckman@users.noreply.github.com>

Author: Copilot

.gitignore

@@ -314,3 +314,4 @@ $RECYCLE.BIN/
 
 # Visual Studio local development settings
 launchSettings.json
+.objs/

build/NI.CSharp.Analyzers.nuspec

@@ -6,7 +6,7 @@
     <!--TODO: author and owner may have to change if we go to nuget.org -->
     <authors>NI</authors>
     <owners>NI</owners>
-    <copyright>Copyright 2025 National Instruments Corporation</copyright>
+    <copyright>Copyright 2024 National Instruments Corporation</copyright>
     <description>NI's code analyzers and rulesets for C# projects.</description>
     <summary>NI's code analyzers and rulesets for C# projects.</summary>
     <developmentDependency>true</developmentDependency>
@@ -22,7 +22,7 @@
           major version, make sure to update AnalysisLevel in NI.CSharp.Analysers.props
           too, otherwise new rules will not be properly enabled.
         -->
-        <dependency id="Microsoft.CodeAnalysis.NetAnalyzers" version="10.0.100" />
+        <dependency id="Microsoft.CodeAnalysis.NetAnalyzers" version="9.0.0" />
         <dependency id="Microsoft.CodeAnalysis.CSharp" version="4.2.0" />
         <dependency id="Microsoft.CodeAnalysis.Analyzers" version="3.3.3" />
         <dependency id="Microsoft.VisualStudio.Threading.Analyzers" version="17.10.48" />

nuget.config

@@ -5,8 +5,5 @@
     <add key="automatic" value="True" />
   </packageRestore>
   <packageSources>
-    <!-- `clear` ensures no additional sources are inherited from another config file. -->
-    <clear />
-    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
   </packageSources>
 </configuration>

src/AnalyzerConfiguration/NI.CSharp.Analyzers.props

@@ -31,12 +31,12 @@
     <AnalysisMode Condition="'$(AnalysisMode)' == ''">NI</AnalysisMode>
 
     <!--
-      If AnalysisLevel is not set, the .NET SDK will default to the version of the SDK.  If the SDK is less than .NET 10,
-      then despite having a .NET 10 analyzer nuget referenced, we will use the lower SDK version as the analysis level.
+      If AnalysisLevel is not set, the .NET SDK will default to the version of the SDK.  If the SDK is less than .NET 9,
+      then despite having a .NET 9 analyzer nuget referenced, we will use the lower SDK version as the analysis level.
 
-      Thus we manually set the default analysis level to 10.0 to make sure .NET 10 warnings are still checked.
+      Thus we manually set the default analysis level to 9.0 to make sure .NET 9 warnings are still checked.
     -->
-    <AnalysisLevel Condition="'$(AnalysisLevel)' == ''">10.0</AnalysisLevel>
+    <AnalysisLevel Condition="'$(AnalysisLevel)' == ''">9.0</AnalysisLevel>
   </PropertyGroup>
 
   <!-- 

src/AnalyzerConfiguration/NI.CSharp.Analyzers.targets

@@ -48,7 +48,7 @@
     <Analyzer Include="$(PkgStyleCop_Analyzers_Unstable)\analyzers\dotnet\cs\StyleCop.Analyzers.CodeFixes.dll"/>
 
     <!-- Microsoft's CA analyzers -->
-    <Analyzer Include="$(PkgMicrosoft_CodeAnalysis_NetAnalyzers)\analyzers\dotnet\Microsoft.CodeAnalysis.NetAnalyzers.dll"/>
+    <Analyzer Include="$(PkgMicrosoft_CodeAnalysis_NetAnalyzers)\analyzers\dotnet\cs\Microsoft.CodeAnalysis.NetAnalyzers.dll"/>
     <Analyzer Include="$(PkgMicrosoft_CodeAnalysis_NetAnalyzers)\analyzers\dotnet\cs\Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll"/>
     <Analyzer Include="$(PkgMicrosoft_VisualStudio_Threading_Analyzers)\analyzers\cs\Microsoft.VisualStudio.Threading.Analyzers.dll"/>