Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master to main ? #880

Closed
PompeiaPaetenari opened this issue Mar 10, 2021 · 5 comments
Closed

Rename master to main ? #880

PompeiaPaetenari opened this issue Mar 10, 2021 · 5 comments

Comments

@PompeiaPaetenari
Copy link
Contributor

We just got a company memo to do this... and as we pull in your repo, it means that the master branch is seen on the fork by their scanners. Curious if you are able/willing to do this for SwiftFormat? :D. Not high priority, but it would be cool.

https://github.com/github/renaming

Thanks!!

@nicklockwood
Copy link
Owner

I actually tried this before, but found that it broke integration with Mint. I'll see if that's now been resolved.

@rastersize
Copy link

rastersize commented Mar 23, 2021

@nicklockwood I ran into the same issue with a repo of mine - that was created with a default branch named main. This PR yonaskolb/Mint#204 (or something like it) needs to be merged into Mint for it to work. Along with a new version of Mint that is.

@gwynne
Copy link
Contributor

gwynne commented Apr 12, 2023

@nicklockwood Can this be revisited? Mint apparently still hasn't shown the slightest interest, and every package that lets them get away with it is providing that much less incentive to put forth the fairly trivial effort involved. You can always just say mint install nicklockwood/SwiftFormat@main instead, the way this package started advising its users to do. (I am not a Mint user, admittedly; TBH I'd never heard of it until I read the discussion in this issue.)

Edit: IIRC, GitHub keeps the automagic master -> main redirect after you rename the branch for a long time, so it's... "impressive", in a way, that Mint managed to be broken by the change in the first place.

@nicklockwood
Copy link
Owner

@gwynne agreed, they've had enough time. It's a breaking change so I'll leave it for a 0.x release, but I'll make a note to do this.

@nicklockwood
Copy link
Owner

I've renamed master to main, and added the suggested workaround for Mint in the README. I've done it in advance of the next release since it doesn't seem like anything in the actual code needs to change. There's a small possibility I may have to roll back if there are issues with the release, but everything seems OK so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants