Arithmetic priorities mult/div and plus/minus

[GloomyLemon]

The grammar is not correctly giving equal priority to conventionally equal operators:

    | expression TIMES expression                               #ExprMultiplication
	| expression DIVIDE expression                              #ExprDivision
	| expression PLUS expression                                #ExprAddition
	| expression MINUS expression                               #ExprSubtraction

Furthermore, there are issues concerning adding negative numbers (e.g. 3 + - 5 or 3 + ( -5)), as the grammar does not support these expressions properly.

[GloomyLemon]

Here is a test case that fails because of the wrong priorities.

import unittest
from rtamt import StlDenseTimeSpecification


class TestIssue180(unittest.TestCase):
    def __init__(self, *args, **kwargs):
        super(TestIssue180, self).__init__(*args, **kwargs)

    def test_issue_180_1(self):
        spec1 = StlDenseTimeSpecification()
        spec1.spec = "firstTerm - 10 + 10"
        spec1.declare_var("firstTerm", "float")
        spec1.parse()

        spec2 = StlDenseTimeSpecification()
        spec2.spec = "firstTerm / 10 * 10"
        spec2.declare_var("firstTerm", "float")
        spec2.parse()

        rob1 = spec1.update(['firstTerm', [(0, 25), (10, 75), (20, 100)]])
        result1 = [[0, 25], [10, 75], [20, 100]]
        print('spec1: ' + str(rob1))

        rob2 = spec2.update(['firstTerm', [(0, 50), (10, 200), (20, 1000)]])
        result2 = [[0, 50], [10, 200], [20, 1000]]
        print('spec2: ' + str(rob2))

        self.assertListEqual(rob1, result1)
        self.assertListEqual(rob2, result2)

if __name__ == '__main__':
    unittest.main()

[GloomyLemon]

Would it be possible to get a comment or opinion on this issue @nickovic ? I would like this issue to be resolved in the master branch

[nickovic]

Many thanks for identifying and fixing this important issue, very appreciated. I will reviewvthe changes towards merging the request before the endbof this week (and hooefully earlier).

[GloomyLemon]

Thanks.

Let me know if you have questions or remarks, I will try to help or address them