Returned string from overloaded toJSON is being qouted

[rmja]

Following the suggestion from #193 the Value property on my custom JSObject's now inherit from JSObject. This causes the following test to not pass, hence my custom json serializer registered on the global context is not invoked:

I then tried to override the "toJSON" property as follows:

The problem is then that the returned string gets qouted because of the recursive call to stringifyImpl() instead of being returned directly:

Should this code instead be:

if (toJSONmemb._valueType == JSValueType.Function)
                {
                    var json = (toJSONmemb._oValue as Function).Call(obj, null);
                    if (json.Value is string jsonString)
                    {
                        return jsonString;
                    }
                    return stringifyImpl("", json, null, null, space, processed, null);
                }

?

[nilproject]

Unfortunately, this is correct behavior of JSON.stringify with toJSON (see this).
Yes, it's weird, but it's not the only weird place in JS.

I think about this trouble and concluded, that condition about JSValue and it's subclasses should be removed. But it's required to solve problem with performance penalty, which will arise after this.

[nilproject]

Also you can return instance of another type, which not inherits JSValue and passes through this condition.
Or do not inherit JSValue in you current implementation (see this example. Attributes not required, all works without them)

[rmja]

Whoot, year that is strange. Yes, I found that I could return a type not inheriting from JSObject in toJSON. It just thought that it was a bug.

Another "hack" could be to simply return the JSON string directly from toJSON. Then:

if (toJSONmemb._valueType == JSValueType.Function)
     return stringifyImpl("", json, null, null, space, processed, null);
else if (toJSONmemb._valueType == JSValueType.String)
     return (string)toJSONmemb.Value;

I know that it is a hack, but it would avoid introducing the performance regression that you are mentioning.