- obsplus version: master
- Python version: 3.7.4
- Operating System: Ubuntu 18.04
Description
One of the columns in the output of events_to_df is simply called station_count, which is a deviation from the naming convention for the OriginQuality object in obspy, which has an associated_station_count (number of stations at which the event was observed) and an used_station_count (number of stations from which data was used for origin computation). This is mildly confusing because from the label it is ambiguous as to which of these items the value refers to, or if it refers to something else entirely.
Proposed Change
Looking at the source code, it appears that station_count is intended to be the equivalent of used_station_count. I recommend changing the column name to reflect this. This might break things, but it should be relatively easy to update.
Description
One of the columns in the output of
events_to_dfis simply calledstation_count, which is a deviation from the naming convention for theOriginQualityobject in obspy, which has anassociated_station_count(number of stations at which the event was observed) and anused_station_count(number of stations from which data was used for origin computation). This is mildly confusing because from the label it is ambiguous as to which of these items the value refers to, or if it refers to something else entirely.Proposed Change
Looking at the source code, it appears that
station_countis intended to be the equivalent ofused_station_count. I recommend changing the column name to reflect this. This might break things, but it should be relatively easy to update.