Skip to content

Commit 1b1b6fa

Browse files
committed
propagate retention status to metadata; use list instead of generator; correct var name
1 parent 79e840d commit 1b1b6fa

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

nipype/algorithms/confounds.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ def _run_interface(self, runtime):
667667
f.write('\t'.join(['component'] + list(metadata.keys())) + '\n')
668668
for i in zip(components_names, *metadata.values()):
669669
f.write('{0[0]}\t{0[1]}\t{0[2]:.10f}\t'
670-
'{0[3]:.10f}\t{0[4]:.10f}\n'.format(i))
670+
'{0[3]:.10f}\t{0[4]:.10f}\t{0[5]}\n'.format(i))
671671

672672
return runtime
673673

@@ -1268,7 +1268,7 @@ def compute_noise_components(imgseries, mask_images, components_criterion=0.5,
12681268
components_criterion = -1
12691269
mask_names = mask_names or range(len(mask_images))
12701270

1271-
comp_list = []
1271+
components = []
12721272
md_mask = []
12731273
md_sv = []
12741274
md_var = []
@@ -1345,8 +1345,8 @@ def compute_noise_components(imgseries, mask_images, components_criterion=0.5,
13451345
md_sv.append(s)
13461346
md_var.append(variance_explained)
13471347
md_cumvar.append(cumulative_variance_explained)
1348-
md_retained.append(i < num_components for i in range(len(s)))
1349-
1348+
md_retained.append([i < num_components for i in range(len(s))])
1349+
13501350
if len(components) > 0:
13511351
components = np.hstack(components)
13521352
else:
@@ -1355,13 +1355,13 @@ def compute_noise_components(imgseries, mask_images, components_criterion=0.5,
13551355
components = np.full((M.shape[0], num_components),
13561356
np.nan, dtype=np.float32)
13571357

1358-
metadata = OrderedDict(
1358+
metadata = OrderedDict([
13591359
('mask', list(chain(*md_mask))),
13601360
('singular_value', np.hstack(md_sv)),
13611361
('variance_explained', np.hstack(md_var)),
13621362
('cumulative_variance_explained', np.hstack(md_cumvar)),
13631363
('retained', list(chain(*md_retained)))
1364-
)
1364+
])
13651365

13661366
return components, basis, metadata
13671367

0 commit comments

Comments
 (0)