Skip to content

Normalize runtime threads in gantt chart #3700

Description

@effigies

#3290 restored gantt chart functionality. The PR was generally delayed by a concern that the thread representation is misleading.

The proposed solution is:

if status_dict['runtime_threads'] != "N/A":
    status_dict['runtime_threads'] //= 100

I believe here:

status_dict = {
"name": node.name,
"id": node._id,
"start": node.result.runtime.startTime,
"finish": node.result.runtime.endTime,
"duration": node.result.runtime.duration,
"runtime_threads": getattr(node.result.runtime, "cpu_percent", "N/A"),
"runtime_memory_gb": getattr(node.result.runtime, "mem_peak_gb", "N/A"),
"estimated_memory_gb": node.mem_gb,
"num_threads": node.n_procs,
}
if status_dict["start"] is None or status_dict["finish"] is None:
status_dict["error"] = True

cc @shnizzedy

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions