Skip to content

generated disko format hits shellcheck warnings, causing new luks-btrfs-raid-non-root test to fail #1099

@SolidEva

Description

@SolidEva

while testing #1098

❯ nix build --no-link ".#checks.x86_64-linux.luks-btrfs-raid-non-root"
warning: Git tree '/home/eva/repos/disko' is dirty
evaluation warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
error: builder for '/nix/store/dwj0x1w3sphr78gav73kd0dnrj296anc-disko-format.drv' failed with exit code 1;
       last 25 log lines:
       >
       >
       > In /nix/store/4d9cm1sv51glxlfvbid2m1gqkhx862xp-disko-format line 355:
       >       IFS= read -r -s "$var"
       >                       ^----^ SC2229 (warning): This does not read 'var'. Remove $/${} for that, or use ${var?} to quiet.
       >
       >
       > In /nix/store/4d9cm1sv51glxlfvbid2m1gqkhx862xp-disko-format line 364:
       >         export password
       >                ^------^ SC2031 (info): password was modified in a subshell. That change might be lost.
       >
       >
       > In /nix/store/4d9cm1sv51glxlfvbid2m1gqkhx862xp-disko-format line 365:
       >         [ "$password" = "$password_check" ]
       >            ^-------^ SC2031 (info): password was modified in a subshell. That change might be lost.
       >
       >
       > In /nix/store/4d9cm1sv51glxlfvbid2m1gqkhx862xp-disko-format line 368:
       >         export password=disko
       >                ^------^ SC2031 (info): password was modified in a subshell. That change might be lost.
       >
       > For more information:
       >   https://www.shellcheck.net/wiki/SC2154 -- password_check is referenced but ...
       >   https://www.shellcheck.net/wiki/SC2229 -- This does not read 'var'. Remove ...
       >   https://www.shellcheck.net/wiki/SC2030 -- Modification of password is local...
       For full logs, run:
         nix log /nix/store/dwj0x1w3sphr78gav73kd0dnrj296anc-disko-format.drv
error: 1 dependencies of derivation '/nix/store/p28v5l27yyd24asb87fgfb449am2nmpn-nixos-test-driver-disko-luks-btrfs-raid-non-root.drv' failed to build
error: 1 dependencies of derivation '/nix/store/lydfhigmi2x9h18s0iyjy05jx8s9hi2p-vm-test-run-disko-luks-btrfs-raid-non-root.drv' failed to build

looking at the full log, we also hit the following warning:

In /nix/store/4d9cm1sv51glxlfvbid2m1gqkhx862xp-disko-format line 146:
        [ "$password" = "$password_check" ]
                         ^-------------^ SC2154 (warning): password_check is referenced but not assigned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions