Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add support for additional checkbox tokens #2578

Open
AlineNap opened this issue Oct 21, 2024 · 1 comment
Open

feature request: add support for additional checkbox tokens #2578

AlineNap opened this issue Oct 21, 2024 · 1 comment
Labels
component/checkbox enhancement New feature or request

Comments

@AlineNap
Copy link

AlineNap commented Oct 21, 2024

Dit issue is wellicht relevant/ dubbel: #2355

Om een filled checkbox te kunnen stijlen zijn de volgende design tokens nodig per state, de radio-button is al wel zo opgebouwd. Kijk daar voor inspiratie en consistentie:

  • utrecht.checkbox.checked.active.background-color
  • utrecht.checkbox.checked.active.border-color
  • utrecht.checkbox.checked.active.color
  • utrecht.checkbox.checked.active.border-width

Herhaal dit voor focus (of moet dat focus-visable worden?), hover, disabled en invalid (heeft radio disabled en invalid?).

Zelfde tokens zijn nodig voor indeterminate. Tenzij we besluiten dat die altijd hetzelfde gestijld wordt als checked. De tokens:

  • utrecht.checkbox.indeterminate.active.background-color
  • utrecht.checkbox.indeterminate.active.border-color
  • utrecht.checkbox.indeterminate.active.color
  • utrecht.checkbox.indeterminate.active.border-width

Dit issue is ook relevant voor: https://github.com/orgs/nl-design-system/projects/60/views/3?filterQuery=&pane=issue&itemId=82712799&issue=nl-design-system%7Cutrecht%7C2516

@Robbert
Copy link
Member

Robbert commented Nov 4, 2024

Goed idee

@jeffreylauwers jeffreylauwers changed the title Feature request: filled checked checkbox stijlen met design tokens feature request: filled checked checkbox stijlen met design tokens Feb 13, 2025
@jeffreylauwers jeffreylauwers changed the title feature request: filled checked checkbox stijlen met design tokens feature request: add support for additional checkbox tokens Feb 13, 2025
@jeffreylauwers jeffreylauwers added the enhancement New feature or request label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/checkbox enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants