New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollLink scrollt naar boven, zelfs als `href="#somewhere-else"` #2728

Open

Robbert opened this issue Feb 17, 2025 · 0 comments

Labels

bug component/scroll-link

Member

Robbert commented Feb 17, 2025

Met ...restProps is het mogelijk (en de bedoeling) om href te kunnen aanpassen van de default #top.

https://github.com/nl-design-system/utrecht/blob/main/packages/component-library-react/src/ScrollLink.tsx#L9-L27

Ideeën in pseudo code:

{ href = '#top' } zou misschien duidelijker aangeven dat het bedoeld is als aanpasbare property
scrollen optioneel maken if (href === '#' || href === '#top') scrollToTop()
fragmentIdentifier = parseUrlAndGetFragment(href) en document.getElementById(fragmentIdentifier).scrollIntoView()

The text was updated successfully, but these errors were encountered:

Robbert added bug component/scroll-link labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment