Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Country codes using the additional ISO-3166-1 should not be saved as lowercase #43

Open
AmineI opened this issue Apr 10, 2019 · 0 comments
Open

Country codes using the additional ISO-3166-1 should not be saved as lowercase #43

AmineI opened this issue Apr 10, 2019 · 0 comments

Comments

@AmineI
Copy link

AmineI commented Apr 10, 2019 •
edited
Loading

By using #39, we noticed setting pt-BR as a language works properly but not pt-br or PT-BR.
However, when submitted by an user in the options windows, the extension always change the entered string to lowercase, making these languages to not work properly.

The case should thus be properly changed to (lowercase)-(UPPERCASE) for these "long" languages codes, when submitted in the extension's options windows
@AmineI AmineI changed the title country codes using the additional ISO-3166-1 should not be set to lowercase Country codes using the additional ISO-3166-1 should not be set to full lowercase Apr 10, 2019
@AmineI AmineI changed the title Country codes using the additional ISO-3166-1 should not be set to full lowercase Country codes using the additional ISO-3166-1 should not be saved as lowercase May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AmineI