Make sure tests can be run offline and by adding new cmake switch

[LocutusOfBorg]

As said, I would like to package test_data jsons in Debian...

[coveralls]

coverage: 99.191%. remained the same
when pulling c0476f3 on LocutusOfBorg:develop
into 8deac49 on nlohmann:develop.

[github-actions]

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

[LocutusOfBorg]

rebased

[LocutusOfBorg]

json-test-data is now part of sid, and I removed the hardcoded version from the directory. @nlohmann can you please have another look? thanks

[nlohmann]

I think the idea of the PR can be achieved by adding test labels and leaving the CMake files as is. Then a test directory can be passed via -DJSON_TEST_DATA_DIR=... and tests that require internet can be excluded via ctest -LE ....

[LocutusOfBorg]

So nothing left to merge :D

[nlohmann]

No, I think you still need to annotate the tests that require internet so you can skip those.

[LocutusOfBorg]

@nlohmann the tests requiring git are the same requiring internet :)
Maybe git_required should be changed into network_required, because they need git to clone from network, but looks too much to add another label just for the same purpose?

[nlohmann]

I'd rather not add an alias label. However, maybe this text from the README could be updated:

In case you have downloaded the library rather than checked out the code via Git, test cmake_fetch_content_configure will fail. Please execute ctest -LE git_required to skip these tests. See #2189 for more information.

Thoughts?

[nlohmann]

Please revert this change. Renaming the label will be breaking other people's workflows.

[LocutusOfBorg]

What do you think about this one?

[nlohmann]

No, please do not add another label. This is all complexity down the road. I think a note to the README that if somebody wants to execute the test suite without internet, then git_required is there to help.

(Sorry for being so insistent, but this is a side project, and I have to be careful of adding stuff.)

[LocutusOfBorg]

ack done

[nlohmann]

Looks good to me.

[nlohmann]

Thanks!

[LocutusOfBorg]

thanks to you!