feat: use getByte() instead of get()

improve read performance

node-modules/byte#29

Author: fengmk2

.gitignore

@@ -16,4 +16,5 @@ node_modules
 .DS_Store
 coverage.html
 coverage/
-.idea/
+.idea/
+profile-*/

benchmark/decode.js

@@ -1,19 +1,5 @@
-/**!
- * hessian.js - benchmark/decode.js
- *
- * Copyright(c) fengmk2 and other contributors.
- * MIT Licensed
- *
- * Authors:
- *   fengmk2 <[email protected]> (http://fengmk2.github.com)
- */
-
 'use strict';
 
-/**
- * Module dependencies.
- */
-
 var ByteBuffer = require('byte');
 var Benchmark = require('benchmark');
 var benchmarks = require('beautify-benchmark');

benchmark/encode.js

@@ -1,19 +1,5 @@
-/**!
- * hessian.js - benchmark/encode.js
- *
- * Copyright(c) fengmk2 and other contributors.
- * MIT Licensed
- *
- * Authors:
- *   fengmk2 <[email protected]> (http://fengmk2.github.com)
- */
-
 'use strict';
 
-/**
- * Module dependencies.
- */
-
 var ByteBuffer = require('byte');
 var Benchmark = require('benchmark');
 var benchmarks = require('beautify-benchmark');

benchmark/encoder.v1.read.js

@@ -0,0 +1,49 @@
+'use strict';
+
+var bench = require('fastbench');
+var java = require('js-to-java');
+var hessian = require('..');
+
+var max = 10;
+
+var complexObject = {
+  $class: 'com.hessiantest.org.MockRequest',
+  $: {
+    id: 123,
+    name: 'getData',
+    args: [1, makeStr('name', 1), makeStr('a', 200)],
+    conn: {
+      $class: 'com.hessiantest.org.MockRequestConnection',
+      $: {
+        ctx: java.long(1024),
+        name: makeStr('p', 200),
+      }
+    }
+  }
+};
+var complexObjectBuf = hessian.encode(complexObject, '1.0');
+console.log(hessian.decode(complexObjectBuf, '1.0', true));
+
+var run = bench([
+  function readComplexObject(cb) {
+    for (var i = 0; i < max; i++) {
+      hessian.decode(complexObjectBuf, '1.0', true);
+    }
+    setImmediate(cb);
+  },
+], 10000);
+
+run(run);
+
+function makeStr(str, concats) {
+  var s = ''
+  while (concats--) {
+    s += str
+  }
+  return s
+}
+
+// node benchmark/encoder.v1.write.js
+// 360 <Buffer 4d 74 00 1f 63 6f 6d 2e 68 65 73 73 69 61 6e 74 65 73 74 2e 6f 72 67 2e 4d 6f 63 6b 52 65 71 75 65 73 74 53 00 02 69 64 49 00 00 00 7b 53 00 04 6e 61 ... >
+// writeComplexObject*10000: 1214.816ms
+// writeComplexObject*10000: 1151.431ms

benchmark/encoder.v1.write.js

@@ -0,0 +1,61 @@
+'use strict';
+
+var bench = require('fastbench');
+var java = require('js-to-java');
+var hessian = require('..');
+
+var max = 10;
+
+var complexObject = {
+  $class: 'com.hessiantest.org.MockRequest',
+  $: {
+    id: 123,
+    name: 'getData',
+    args: [1, makeStr('name', 1), makeStr('a', 200)],
+    conn: {
+      $class: 'com.hessiantest.org.MockRequestConnection',
+      $: {
+        ctx: java.long(1024)
+      }
+    }
+  }
+};
+console.log(hessian.encode(complexObject, '1.0').length, hessian.encode(complexObject, '1.0'));
+
+var run = bench([
+  function writeComplexObject(cb) {
+    for (var i = 0; i < max; i++) {
+      var complexObject = {
+        $class: 'com.hessiantest.org.MockRequest',
+        $: {
+          id: 123,
+          name: 'getData',
+          args: [1, makeStr('name', 1), makeStr('a', 200)],
+          conn: {
+            $class: 'com.hessiantest.org.MockRequestConnection',
+            $: {
+              ctx: java.long(1024)
+            }
+          }
+        }
+      };
+      hessian.encode(complexObject, '1.0');
+    }
+    setImmediate(cb);
+  },
+], 10000);
+
+run(run);
+
+function makeStr(str, concats) {
+  var s = ''
+  while (concats--) {
+    s += str
+  }
+  return s
+}
+
+// node benchmark/encoder.v1.write.js
+// 360 <Buffer 4d 74 00 1f 63 6f 6d 2e 68 65 73 73 69 61 6e 74 65 73 74 2e 6f 72 67 2e 4d 6f 63 6b 52 65 71 75 65 73 74 53 00 02 69 64 49 00 00 00 7b 53 00 04 6e 61 ... >
+// writeComplexObject*10000: 1214.816ms
+// writeComplexObject*10000: 1151.431ms

benchmark/encoder.v2.write.js

@@ -54,3 +54,8 @@ function makeStr(str, concats) {
   }
   return s
 }
+
+// node benchmark/encoder.v2.write.js 
+// 324 <Buffer 43 1f 63 6f 6d 2e 68 65 73 73 69 61 6e 74 65 73 74 2e 6f 72 67 2e 4d 6f 63 6b 52 65 71 75 65 73 74 94 02 69 64 04 6e 61 6d 65 04 61 72 67 73 04 63 6f ... >
+// writeComplexObject*10000: 1162.727ms
+// writeComplexObject*10000: 1032.622ms

lib/v1/decoder.js

@@ -1,13 +1,3 @@
-/**
- * hessian.js - lib/v1/decoder.js
- * Copyright(c)
- * MIT Licensed
- *
- * Authors:
- *   dead_horse <[email protected]> (http://deadhorse.me)
- *   fengmk2 <[email protected]> (http://fengmk2.github.com)
- */
-
 'use strict';
 
 var debug = require('debug')('hessian:v1:decoder');
@@ -261,7 +251,7 @@ proto._readUTF8String = function (len) {
   }
 
   while (len--) {
-    head = this.byteBuffer.get();
+    head = this.byteBuffer.getByte();
     l = utils.lengthOfUTF8(head);
     this.byteBuffer.skip(l - 1);
   }
@@ -286,11 +276,11 @@ proto._readUTF8String = function (len) {
  */
 proto.readString = function (withType) {
   var str = '';
-  var code = this.byteBuffer.get();
+  var code = this.byteBuffer.getByte();
   // get all trunk start with 's'
   while (code === 0x73) {
     str += this._readUTF8String();
-    code = this.byteBuffer.get();
+    code = this.byteBuffer.getByte();
   }
 
   if (code === 0x53) {

lib/v1/encoder.js

@@ -1,13 +1,3 @@
-/**
- * hessian.js - lib/encoder.js
- * Copyright(c)
- * MIT Licensed
- *
- * Authors:
- *   dead_horse <[email protected]> (http://deadhorse.me)
- *   fengmk2 <[email protected]> (http://fengmk2.github.com)
- */
-
 'use strict';
 
 var ByteBuffer = require('byte');
@@ -156,7 +146,6 @@ proto.writeBytes = function (buf) {
  *   S 0x00 0x03 [0x01 0x02 0x03]
  */
 proto.writeString = function (str) {
-  this._assertType('writeString', 'string', str);
   var offset = 0;
 
   var length = str.length;
@@ -307,7 +296,7 @@ proto._writeObject = function (obj) {
  * : {$class: 'java.lang.Map', $: {a: 1}}
  */
 proto.writeObject = function (obj) {
-  if (is.nullOrUndefined(obj) || 
+  if (is.nullOrUndefined(obj) ||
     // : { a: { '$class': 'xxx', '$': null } }
     (is.string(obj.$class) && is.nullOrUndefined(obj.$))) {
     debug('writeObject with a null');