-
Notifications
You must be signed in to change notification settings - Fork 305
Nss2esm hybrid #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bourgeoa
wants to merge
30
commits into
main
Choose a base branch
from
nss2esm-hybrid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nss2esm hybrid #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert Windows CRLF line endings to Unix LF in bin/solid script - Add .gitattributes to enforce proper line endings for executable files - Fixes Docker CI error: 'node\r': No such file or directory
- Create ESM versions (.mjs) for 7 main lib files: - capability-discovery.mjs - ldp-container.mjs - ldp.mjs (large 632-line file) - payment-pointer-discovery.mjs - rdf-notification-template.mjs - resource-mapper.mjs (227 lines) - server-config.mjs - Convert lib/api/ directory to ESM: - index.mjs - accounts/user-accounts.mjs - authn/index.mjs - authn/force-user.mjs - All files maintain dual CommonJS/ESM compatibility - Proper import/export conversions with createRequire for CommonJS deps - No errors detected in new ESM modules - Total: 18 .mjs files now available in lib/ directory
lib/api/ conversion completed: - authn/webid-tls.mjs (70 lines - TLS authentication) - authn/webid-oidc.mjs (203 lines - OIDC authentication) lib/handlers/ conversion completed (7 new .mjs files): - restrict-to-top-domain.mjs (simple middleware) - options.mjs (HTTP OPTIONS handler) - index.mjs (directory index handler) - auth-proxy.mjs (authentication proxy) - cors-proxy.mjs (96 lines - CORS proxy with IP filtering) - notify.mjs (149 lines - notification system) - error-pages.mjs (213 lines - error handling & databrowser) Progress: - lib/ main files: 9/9 converted - lib/api/: 6/6 converted - lib/handlers/: 14/14 converted - All new modules error-free and maintain dual compatibility
This reverts commit b370ff7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hybrid conversion step 1 with hybrid tests