chore(lint): report error on invalid change versions, except when REPLACEME

Author: avivkeller

src/linter/rules/invalid-change-version.mjs

@@ -19,11 +19,11 @@ export const invalidChangeVersion = entry => {
     );
 
   const invalidVersions = allVersions.filter(
-    version => valid(version) === null
+    version => version !== 'REPLACEME' && valid(version) === null
   );
 
   return invalidVersions.map(version => ({
-    level: 'warn',
+    level: 'error',
     message: LINT_MESSAGES.invalidChangeVersion.replace('{{version}}', version),
     location: {
       path: entry.api_doc_source,

src/linter/tests/fixtures/entries.mjs

@@ -39,6 +39,11 @@ export const assertEntry = {
       'pr-url': 'https://github.com/nodejs/node/pull/34001',
       description: "Exposed as `require('node:assert/strict')`.",
     },
+    {
+      version: 'REPLACEME',
+      'pr-url': 'https://github.com/nodejs/node/pull/12345',
+      description: 'This is a test entry.',
+    },
   ],
   heading: {
     type: 'heading',

src/linter/tests/rules/invalid-change-version.test.mjs

@@ -13,12 +13,15 @@ describe('invalidChangeVersion', () => {
   it('should return an issue if a change version is invalid', () => {
     const issues = invalidChangeVersion({
       ...assertEntry,
-      changes: [...assertEntry.changes, { version: ['v13.9.0', 'REPLACEME'] }],
+      changes: [
+        ...assertEntry.changes,
+        { version: ['v13.9.0', 'INVALID_VERSION'] },
+      ],
     });
 
     deepEqual(issues, [
       {
-        level: 'warn',
+        level: 'error',
         location: {
           path: 'doc/api/assert.md',
           position: {
@@ -34,7 +37,7 @@ describe('invalidChangeVersion', () => {
             },
           },
         },
-        message: 'Invalid version number: REPLACEME',
+        message: 'Invalid version number: INVALID_VERSION',
       },
     ]);
   });