avoid unnecessary copy

anonrig · anonrig · commit 96b11ffc85c5 · 2026-01-20T15:32:47.000-05:00
diff --git a/src/parser.cpp b/src/parser.cpp
@@ -1385,14 +1385,14 @@ class CJSLexer {
   }
 };
 
-std::optional<lexer_analysis> parse_commonjs(const std::string_view file_contents) {
+std::optional<lexer_analysis> parse_commonjs(std::string_view file_contents) {
   last_error.reset();
 
   lexer_analysis result;
   CJSLexer lexer(result.exports, result.re_exports);
 
   if (lexer.parse(file_contents)) {
-    return result;
+    return result;  // NRVO or implicit move applies
   }
 
   return std::nullopt;

Original file line number	Diff line number	Diff line change
`@@ -1385,14 +1385,14 @@ class CJSLexer {`
`1385`	`1385`	`}`
`1386`	`1386`	`};`
`1387`	`1387`
`1388`		`-std::optional<lexer_analysis> parse_commonjs(const std::string_view file_contents) {`
	`1388`	`+std::optional<lexer_analysis> parse_commonjs(std::string_view file_contents) {`
`1389`	`1389`	`last_error.reset();`
`1390`	`1390`
`1391`	`1391`	`lexer_analysis result;`
`1392`	`1392`	`CJSLexer lexer(result.exports, result.re_exports);`
`1393`	`1393`
`1394`	`1394`	`if (lexer.parse(file_contents)) {`
`1395`		`- return result;`
	`1395`	`+ return result; // NRVO or implicit move applies`
`1396`	`1396`	`}`
`1397`	`1397`
`1398`	`1398`	`return std::nullopt;`