Skip to content

Commit d796dd5

Browse files
authoredAug 7, 2024
fix(git-node): ignore codecov check suite (#838)
1 parent 25ea992 commit d796dd5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed
 

‎lib/pr_checker.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED'];
2929
const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/;
3030
const FAST_TRACK_MIN_APPROVALS = 2;
3131
const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork';
32+
const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov'];
3233

3334
// eslint-disable-next-line no-extend-native
3435
Array.prototype.findLastIndex ??= function findLastIndex(fn) {
@@ -373,9 +374,9 @@ export default class PRChecker {
373374

374375
// GitHub new Check API
375376
for (const { status, conclusion, app } of checkSuites.nodes) {
376-
if (app && app.slug === 'dependabot') {
377-
// Ignore Dependabot check suites. They are expected to show up
378-
// sometimes and never complete.
377+
if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) {
378+
// Ignore Dependabot and Codecov check suites.
379+
// They are expected to show up sometimes and never complete.
379380
continue;
380381
}
381382

0 commit comments

Comments
 (0)