worker: heap profile optimizations

IlyasShabi · IlyasShabi · commit a81087a10b34 · 2026-03-12T11:26:40.000+01:00
diff --git a/src/node_worker.cc b/src/node_worker.cc
@@ -1121,7 +1121,8 @@ static bool serializeProfile(Isolate* isolate, std::ostringstream& out_stream) {
   if (!profile) {
     return false;
   }
-  JSONWriter writer(out_stream, false);
+  profiler->StopSamplingHeapProfiler();
+  JSONWriter writer(out_stream, true);
   writer.json_start();
 
   writer.json_arraystart("samples");
@@ -1139,7 +1140,6 @@ static bool serializeProfile(Isolate* isolate, std::ostringstream& out_stream) {
   writer.json_objectend();
 
   writer.json_end();
-  profiler->StopSamplingHeapProfiler();
   return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1121,7 +1121,8 @@ static bool serializeProfile(Isolate* isolate, std::ostringstream& out_stream) {`
`1121`	`1121`	`if (!profile) {`
`1122`	`1122`	`return false;`
`1123`	`1123`	`}`
`1124`		`- JSONWriter writer(out_stream, false);`
	`1124`	`+ profiler->StopSamplingHeapProfiler();`
	`1125`	`+ JSONWriter writer(out_stream, true);`
`1125`	`1126`	`writer.json_start();`
`1126`	`1127`
`1127`	`1128`	`writer.json_arraystart("samples");`
`@@ -1139,7 +1140,6 @@ static bool serializeProfile(Isolate* isolate, std::ostringstream& out_stream) {`
`1139`	`1140`	`writer.json_objectend();`
`1140`	`1141`
`1141`	`1142`	`writer.json_end();`
`1142`		`- profiler->StopSamplingHeapProfiler();`
`1143`	`1143`	`return true;`
`1144`	`1144`	`}`
`1145`	`1145`