-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Open
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Description
After the recursive
option was added to readdir
and opendir
, it was noted that when specifying bufferSize
alongside recursive: true
, the result of opendir
was incorrect. This is fixed in #55744 . However, the fix is a naive solution, and doesn't properly respect the bufferSize
option. Furthermore, it could result in a blocked event loop. This should be fixed.
I recommend reading the discussion in #48820 for more information. This should only involve changes to the Dir
class in lib/internal/fs/dir.js
.
Metadata
Metadata
Assignees
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.