Skip to content

Conversation

@LiviaMedeiros
Copy link
Member

Extracted from: #58793

Test accessing all properties on builtin modules.
The only allowed error is accessing property on prototype when it is available only on actual instances. These are always TypeErrors, always on prototype, and either an ERR_INVALID_THIS or an error without code (typically caused by trying to read private properties in getter).

@LiviaMedeiros LiviaMedeiros added module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. labels Nov 27, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (4451309) to head (6972aeb).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60871      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.02%     
==========================================
  Files         703      703              
  Lines      208259   208291      +32     
  Branches    40187    40216      +29     
==========================================
+ Hits       184454   184458       +4     
- Misses      15812    15846      +34     
+ Partials     7993     7987       -6     

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants