Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Multiple CPU temp sensors (or don't use Tctl) #141

Open
DaveKram opened this issue Dec 30, 2023 · 2 comments
Open

Feature request: Multiple CPU temp sensors (or don't use Tctl) #141

DaveKram opened this issue Dec 30, 2023 · 2 comments

Comments

@DaveKram
Copy link

DaveKram commented Dec 30, 2023

First off, great application!

Something to consider, is that with some CPUs, more than one temperature sensor is reported under sysfs hwmon.

A quick look at the code shows you using just temp1_input to display. temp1_input is Tctl and used for fan control, and not really the actual useful CPU temperatures Kernel driver k10temp Description about multiple sensors.

For instance, doing a: watch -n1 sensors on my machine (I have an AMD 7900x3D), I have:

Screenshot from 2023-12-30 11-12-49

My suggestion is to display all available temp_input files via sysfs on the GUI, or show something other than Tctl. I don't believe I saw another issue around this, so apologies if it already exists.

Again, just a suggestion and something I noticed.

@nokyan
Copy link
Owner

nokyan commented Dec 30, 2023

Hi, thanks for the issue, I'm glad you like Resources! :)
I didn't know that about k10temp, I'll look into it. I'd prefer a single value for the temperature though as I prefer Resources to be simple to use. I'd go for Tdie (temp2_input) then, but your screenshot doesn't seem to have that :/

@DaveKram
Copy link
Author

DaveKram commented Jan 3, 2024

I am the type of person that likes to see what's all available to me, and be able to hide/toggle behavior if I don't want to see things.

My personal preference to show all the temp sensors (since you have the GUI labeled Sensors anyway) - and like I said, maybe a way to toggle those on/off visible (if you don't want to show multiple sensors). Another option is to have a preference option in the settings window for those with multiple temp sensors.

Or you don't have to do any of the above, since it's your app :)

And yes, I don't have any temp2_input in sysfs hwmon for my AMD cpu. Just temp1_input, temp3_input, temp4_input - as is described in the k10 driver description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants