Skip to content

Commit 3c0022b

Browse files
committed
Use ruff to format python files
1 parent 1627bfa commit 3c0022b

6 files changed

Lines changed: 38 additions & 58 deletions

File tree

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ jobs:
4848
run: |
4949
conda env update -n libnomp-dev -f environment-dev.yml
5050
if: steps.cache.outputs.cache-hit != 'true'
51-
- name: Run clang-format check
51+
- name: Check formatting
5252
run: |
5353
./bin/lnchk --chk-fmt

bin/lnchk

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,35 +7,23 @@ set -o pipefail
77
############################
88
# Don't touch what follows #
99
############################
10-
1110
CSRC=
12-
PYSRC=
13-
14-
function setup_clang_format() {
15-
if ! command -v $CLANG_FORMAT >/dev/null 2>&1; then
16-
echo "Binary $CLANG_FORMAT not found!"
17-
exit 1
18-
fi
19-
20-
BINDIR=$(dirname -- "$(realpath -- "${BASH_SOURCE[0]}")")
21-
SRCDIR=$BINDIR/..
22-
CSRC=$(find $SRCDIR -type f -name "*.[ch]")
23-
}
2411

25-
function clang_format() {
26-
setup_clang_format
27-
$CLANG_FORMAT -i $CSRC
28-
}
12+
if ! command -v $CLANG_FORMAT >/dev/null 2>&1; then
13+
echo "Binary $CLANG_FORMAT not found!"
14+
exit 1
15+
fi
2916

30-
function check_clang_format() {
31-
setup_clang_format
32-
$CLANG_FORMAT --dry-run --Werror -i $CSRC
33-
}
17+
BINDIR=$(dirname -- "$(realpath -- "${BASH_SOURCE[0]}")")
18+
CSRC=$(find $BINDIR/.. -type f -name "*.[ch]")
3419

3520
if [[ "$1" == "--fmt" ]]; then
36-
clang_format
21+
$CLANG_FORMAT -i $CSRC
22+
ruff format .
3723
elif [[ "$1" == "--chk-fmt" ]]; then
38-
check_clang_format
24+
$CLANG_FORMAT --dry-run --Werror -i $CSRC
25+
ruff format --check .
26+
ruff check .
3927
else
4028
exit 1
4129
fi

pyproject.toml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
[tool.isort]
2-
multi_line_output = 3
3-
include_trailing_comma = true
4-
force_grid_wrap = 0
5-
use_parentheses = true
6-
line_length = 80
7-
skip_glob = ['build/*', 'docs/*']
1+
[tool.ruff]
2+
line-length = 80
3+
exclude = ["build", "docs"]
84

9-
[tool.black]
10-
line_length = 80
11-
preview = true
12-
exclude = 'build/|docs/'
5+
[tool.ruff.lint]
6+
# Equivalent to the old flake8 rules + isort (I = isort, E/W = pycodestyle, F = pyflakes)
7+
select = ["E", "F", "W", "I"]
8+
9+
[tool.ruff.lint.isort]
10+
# Matches the old isort settings
11+
force-wrap-aliases = false
12+
combine-as-imports = false
1313

1414
[tool.pylint.master]
1515
ignore = "build,docs"

python/loopy_api.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,23 @@
2222
NOMP_VAR_PREFIX = "_nomp_var"
2323

2424
_C_OPS_TO_PYMBOLIC_OPS = {
25-
"*": lambda x, y: prim.Product((x, y)),
26-
"+": lambda x, y: prim.Sum((x, y)),
27-
"-": lambda l, r: prim.Sum((l, prim.Product((-1, r)))),
25+
"*": lambda X, Y: prim.Product((X, Y)),
26+
"+": lambda X, Y: prim.Sum((X, Y)),
27+
"-": lambda L, R: prim.Sum((L, prim.Product((-1, R)))),
2828
"/": prim.Quotient,
2929
"//": prim.FloorDiv,
3030
"%": prim.Remainder,
31-
"<": lambda l, r: prim.Comparison(l, "<", r),
32-
"<=": lambda l, r: prim.Comparison(l, "<=", r),
33-
">": lambda l, r: prim.Comparison(l, ">", r),
34-
">=": lambda l, r: prim.Comparison(l, ">=", r),
35-
"==": lambda l, r: prim.Comparison(l, "==", r),
36-
"!=": lambda l, r: prim.Comparison(l, "!=", r),
37-
"&&": lambda l, r: prim.LogicalAnd((l, r)),
38-
"||": lambda l, r: prim.LogicalOr((l, r)),
39-
"&": lambda l, r: prim.BitwiseAnd((l, r)),
40-
"|": lambda l, r: prim.BitwiseOr((l, r)),
41-
"^": lambda l, r: prim.BitwiseXor((l, r)),
31+
"<": lambda L, R: prim.Comparison(L, "<", R),
32+
"<=": lambda L, R: prim.Comparison(L, "<=", R),
33+
">": lambda L, R: prim.Comparison(L, ">", R),
34+
">=": lambda L, R: prim.Comparison(L, ">=", R),
35+
"==": lambda L, R: prim.Comparison(L, "==", R),
36+
"!=": lambda L, R: prim.Comparison(L, "!=", R),
37+
"&&": lambda L, R: prim.LogicalAnd((L, R)),
38+
"||": lambda L, R: prim.LogicalOr((L, R)),
39+
"&": lambda L, R: prim.BitwiseAnd((L, R)),
40+
"|": lambda L, R: prim.BitwiseOr((L, R)),
41+
"^": lambda L, R: prim.BitwiseXor((L, R)),
4242
"<<": prim.LeftShift,
4343
">>": prim.RightShift,
4444
}

requirements-dev.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
isort==5.10.1
2-
black==24.3.0
3-
flake8==4.0.1
1+
ruff==0.4.4
42
breathe==4.34.0
53
Sphinx==5.1.1
64
sphinx-rtd-theme==1.0.0

setup.cfg

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)