Fails to build on Fedora 36

[ryanpg123]

@fedora keykit]$ make install_linux
if [ ! -d bin ] ; then mkdir bin ; fi
make install_stdio
make[1]: Entering directory '/home/ryanpg/src/keykit'
make copy_stdio
make[2]: Entering directory '/home/ryanpg/src/keykit'
if [ ! -d bin ] ; then mkdir bin ; fi
cp mdep/stdio/mdep1.c src/mdep1.c
cp mdep/stdio/mdep2.c src/mdep2.c
cp mdep/stdio/mdep.h src/mdep.h
cp mdep/stdio/makefile src/makefile
cp mdep/stdio/clock.c src/clock.c
cp mdep/stdio/midi.c src/midi.c
chmod +x mdep/stdio/rmcr
mdep/stdio/rmcr src/.c src/.h src/makefile
mdep/stdio/rmcr echo lib/* | grep -v .ppm
cp mdep/stdio/resetkeylib bin
mdep/stdio/rmcr bin/resetkeylib
chmod +x bin/resetkeylib
mdep/stdio/rmcr tests/*
make[2]: Leaving directory '/home/ryanpg/src/keykit'
cd byacc ; make -f makefile.stdio clobber ; make -f makefile.stdio
make[2]: Entering directory '/home/ryanpg/src/keykit/byacc'
make[2]: Leaving directory '/home/ryanpg/src/keykit/byacc'
make[2]: Entering directory '/home/ryanpg/src/keykit/byacc'
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o closure.o closure.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o error.o error.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o lalr.o lalr.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o lr0.o lr0.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o main.o main.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o mkpar.o mkpar.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o output.o output.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o reader.o reader.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o skeleton.o skeleton.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o symtab.o symtab.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o verbose.o verbose.c
gcc -O -Wno-implicit-int -Wno-builtin-declaration-mismatch -Wno-implicit-function-declaration -c -o warshall.o warshall.c
/usr/bin/ld: main.o: in function create_file_names': main.c:(.text+0x437): warning: the use of mktemp' is dangerous, better use mkstemp' or mkdtemp'
done
make[2]: Leaving directory '/home/ryanpg/src/keykit/byacc'
cd src ; make clean ; make install
make[2]: Entering directory '/home/ryanpg/src/keykit/src'
rm -f d_*.h
rm -f *.o lowkey protoflp keylib
make[2]: Leaving directory '/home/ryanpg/src/keykit/src'
make[2]: Entering directory '/home/ryanpg/src/keykit/src'
gcc -static protoflp.c -o protoflp
./protoflp -p -dd_code.h < code.c > tmp.c
./protoflp -p -dd_code2.h < code2.c > tmp.c
./protoflp -p -dd_fsm.h < fsm.c > tmp.c
./protoflp -p -dd_grid.h < grid.c > tmp.c
./protoflp -p -dd_keyto.h < keyto.c > tmp.c
./protoflp -p -dd_main.h < main.c > tmp.c
./protoflp -p -dd_mdep1.h < mdep1.c > tmp.c
./protoflp -p -dd_menu.h < menu.c > tmp.c
./protoflp -p -dd_mfin.h < mfin.c > tmp.c
./protoflp -p -dd_midi.h < midi.c > tmp.c
./protoflp -p -dd_misc.h < misc.c > tmp.c
./protoflp -p -dd_phrase.h < phrase.c > tmp.c
./protoflp -p -dd_real.h < real.c > tmp.c
./protoflp -p -dd_sym.h < sym.c > tmp.c
./protoflp -p -dd_util.h < util.c > tmp.c
./protoflp -p -dd_view.h < view.c > tmp.c
./protoflp -p -dd_task.h < task.c > tmp.c
./protoflp -p -dd_fifo.h < fifo.c > tmp.c
./protoflp -p -dd_kwind.h < kwind.c > tmp.c
./protoflp -p -dd_regex.h < regex.c > tmp.c
./protoflp -p -dd_bltin.h < bltin.c > tmp.c
./protoflp -p -dd_meth.h < meth.c > tmp.c
./protoflp -p -dd_clock.h < clock.c > tmp.c
./protoflp -p -dd_mdep2.h < mdep2.c > tmp.c
gcc -c yacc.c
gcc -c main.c
gcc -c util.c
gcc -c misc.c
gcc -c phrase.c
gcc -c sym.c
gcc -c keyto.c
gcc -c code.c
gcc -c code2.c
gcc -c grid.c
gcc -c view.c
gcc -c menu.c
gcc -c task.c
gcc -c fifo.c
gcc -c mfin.c
gcc -c real.c
gcc -c mdep1.c
gcc -c mdep2.c
gcc -c kwind.c
gcc -c fsm.c
gcc -c bltin.c
gcc -c meth.c
gcc -c regex.c
gcc -c midi.c
gcc -c clock.c
gcc -static -O yacc.o main.o util.o misc.o phrase.o sym.o keyto.o code.o code2.o grid.o view.o menu.o task.o fifo.o mfin.o real.o mdep1.o mdep2.o kwind.o fsm.o bltin.o meth.o regex.o midi.o clock.o -lm -o lowkey
/usr/bin/ld: main.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here /usr/bin/ld: main.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here
/usr/bin/ld: util.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here /usr/bin/ld: util.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here
/usr/bin/ld: misc.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here /usr/bin/ld: misc.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here
/usr/bin/ld: phrase.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here /usr/bin/ld: phrase.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here
/usr/bin/ld: sym.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here /usr/bin/ld: sym.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here
/usr/bin/ld: sym.o:(.bss+0xc40): multiple definition of Debug'; misc.o:(.data+0x8): first defined here /usr/bin/ld: keyto.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: keyto.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: code.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: code.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: code2.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: code2.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: grid.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: grid.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: view.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: view.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: menu.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: menu.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: task.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: task.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: fifo.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: fifo.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: mfin.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: mfin.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: real.o:(.bss+0x20): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: real.o:(.bss+0x620): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: mdep1.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: mdep1.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: mdep2.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: mdep2.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: kwind.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: kwind.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: fsm.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: fsm.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: bltin.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: bltin.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: meth.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: meth.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: regex.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: regex.o:(.bss+0x600): multiple definition of Midioutputs'; yacc.o:(.bss+0x600): first defined here /usr/bin/ld: midi.o:(.bss+0x0): multiple definition of Midiinputs'; yacc.o:(.bss+0x0): first defined here
/usr/bin/ld: midi.o:(.bss+0x600): multiple definition of `Midioutputs'; yacc.o:(.bss+0x600): first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [makefile:32: lowkey] Error 1
make[2]: Leaving directory '/home/ryanpg/src/keykit/src'
make[1]: *** [makefile:302: install_stdio] Error 2
make[1]: Leaving directory '/home/ryanpg/src/keykit'
make: *** [makefile:409: install_linux] Error 2

[nosuchtim]

I believe these failures have been fixed by commit 0150ad4. Please update to the latest main branch and let us know what issues if any remain.

[ryanpg123]

Thank you, those errors are resolved. But now fails on Fedora with: gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o meth.o /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -o key /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libX11.so.6: No such file or directory /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching for -lm collect2: error: ld returned 1 exit status make[1]: *** [makefile:93: key] Error 1 make[1]: Leaving directory '/home/ryanpg/src/keykit/src' make: *** [makefile:416: install_linux] Error 2 On Fedora libX11.so.6 is found in /usr/lib/libX11.so.6.4.0 however, creating a symlink produced the following: fedora libX11.so.6: error adding symbols: file in wrong format

…

On Thu, Mar 23, 2023 at 5:28 PM Tim Thompson ***@***.***> wrote: I believe these failures have been fixed by commit 0150ad4 <0150ad4>. Please update to the latest main branch and let us know what issues if any remain. — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQVFPG6OI6ACLNBLFM463KDW5TE73ANCNFSM5Z42KRCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pbarada]

Ryan, Try attached patch - it changes the library specification to search for libX11... Peter

On 4/5/23 15:13, Ryan wrote: Thank you, those errors are resolved. But now fails on Fedora with: gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o meth.o /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -o key /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libX11.so.6: No such file or directory /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching for -lm collect2: error: ld returned 1 exit status make[1]: *** [makefile:93: key] Error 1 make[1]: Leaving directory '/home/ryanpg/src/keykit/src' make: *** [makefile:416: install_linux] Error 2 On Fedora libX11.so.6 is found in /usr/lib/libX11.so.6.4.0 however, creating a symlink produced the following: fedora libX11.so.6: error adding symbols: file in wrong format On Thu, Mar 23, 2023 at 5:28 PM Tim Thompson ***@***.***> wrote: > I believe these failures have been fixed by commit 0150ad4 > <0150ad4>. > Please update to the latest main branch and let us know what issues if any > remain. > > — > Reply to this email directly, view it on GitHub > <#10 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AQVFPG6OI6ACLNBLFM463KDW5TE73ANCNFSM5Z42KRCA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMXGSZF5SG2GK5BAIDLZE3W7W753ANCNFSM5Z42KRCA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Peter Barada ***@***.***

[ryanpg123]

Sorry, I'm not finding the patch attached either to email or the github comment.

…

-ry

On Wed, Apr 5, 2023 at 2:24 PM pbarada ***@***.***> wrote: Ryan, Try attached patch - it changes the library specification to search for libX11... Peter On 4/5/23 15:13, Ryan wrote: > Thank you, those errors are resolved. But now fails on Fedora with: > > gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o > main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o > clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o > meth.o > /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm > /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -o key > /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libX11.so.6: No such > file or directory > /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching > for -lm > collect2: error: ld returned 1 exit status > make[1]: *** [makefile:93: key] Error 1 > make[1]: Leaving directory '/home/ryanpg/src/keykit/src' > make: *** [makefile:416: install_linux] Error 2 > > On Fedora libX11.so.6 is found in /usr/lib/libX11.so.6.4.0 however, > creating a symlink produced the following: fedora libX11.so.6: error > adding > symbols: file in wrong format > > > On Thu, Mar 23, 2023 at 5:28 PM Tim Thompson ***@***.***> > wrote: > > > I believe these failures have been fixed by commit 0150ad4 > > > < 0150ad4 >. > > Please update to the latest main branch and let us know what issues > if any > > remain. > > > > — > > Reply to this email directly, view it on GitHub > > <#10 (comment) >, > > or unsubscribe > > > < https://github.com/notifications/unsubscribe-auth/AQVFPG6OI6ACLNBLFM463KDW5TE73ANCNFSM5Z42KRCA > > > . > > You are receiving this because you authored the thread.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > <#10 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABMXGSZF5SG2GK5BAIDLZE3W7W753ANCNFSM5Z42KRCA >. > You are receiving this because you are subscribed to this > thread.Message ID: ***@***.***> > -- Peter Barada ***@***.*** — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQVFPG2LY4V6XA7FKG3OX4TW7XBF3ANCNFSM5Z42KRCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pbarada]

Grr, github doesn't look to handle email attached patches. Try following patch (that specifies "-lX11" instead of explicit path to libX11.so.6 shared library:

diff --git a/mdep/linux/makefile b/mdep/linux/makefile
index c734cd4..27d57bd 100644
--- a/mdep/linux/makefile
+++ b/mdep/linux/makefile
@@ -7,7 +7,7 @@
CC = gcc
STATIC =
SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl
-XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm
+XLIBS = -lX11 -lm
INC = -I/usr/include/
KEY = key

[ryanpg123]

gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o meth.o -lX11 -lm /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -o key /usr/bin/ld: skipping incompatible /usr/lib//libX11.so when searching for -lX11 /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching for -lm /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libasound.so.2: No such file or directory collect2: error: ld returned 1 exit status make[1]: *** [makefile:93: key] Error 1 make[1]: Leaving directory '/home/ryanpg/src/keykit/src' make: *** [makefile:416: install_linux] Error 2 I think the correct directory is /usr/lib64/ "Reality is that which, when you stop believing in it, doesn’t go away." -Philip K. Dick

…

On Wed, Apr 5, 2023 at 2:42 PM pbarada ***@***.***> wrote: Grr, github doesn't look to handle email attached patches. Try following patch (that specifies "-lX11" instead of explicit path to libX11.so.6 shared library: diff --git a/mdep/linux/makefile b/mdep/linux/makefile index c734cd4..27d57bd 100644 --- a/mdep/linux/makefile +++ b/mdep/linux/makefile @@ -7,7 +7,7 @@ CC = gcc STATIC = SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm +XLIBS = -lX11 -lm INC = -I/usr/include/ KEY = key — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQVFPGZDOVNJ22IWAIZNB4DW7XDJDANCNFSM5Z42KRCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pbarada]

Instead of previous patch, try this: diff --git a/mdep/linux/makefile b/mdep/linux/makefile index c734cd4..b028579 100644 --- a/mdep/linux/makefile +++ b/mdep/linux/makefile @@ -6,8 +6,8 @@  CC = gcc  STATIC = -SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm +SOUNDLIBS = -lasound -lpthread -ldl +XLIBS = -lX11 -lm  INC = -I/usr/include/  KEY = key which should remove all explicit path and libraries names needed to link keykit...

On 4/5/23 16:47, Ryan wrote: gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o meth.o -lX11 -lm /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -o key /usr/bin/ld: skipping incompatible /usr/lib//libX11.so when searching for -lX11 /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching for -lm /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libasound.so.2: No such file or directory collect2: error: ld returned 1 exit status make[1]: *** [makefile:93: key] Error 1 make[1]: Leaving directory '/home/ryanpg/src/keykit/src' make: *** [makefile:416: install_linux] Error 2 I think the correct directory is /usr/lib64/ "Reality is that which, when you stop believing in it, doesn’t go away." -Philip K. Dick On Wed, Apr 5, 2023 at 2:42 PM pbarada ***@***.***> wrote: > Grr, github doesn't look to handle email attached patches. Try following > patch (that specifies "-lX11" instead of explicit path to libX11.so.6 > shared library: > > diff --git a/mdep/linux/makefile b/mdep/linux/makefile > index c734cd4..27d57bd 100644 > --- a/mdep/linux/makefile > +++ b/mdep/linux/makefile > @@ -7,7 +7,7 @@ > CC = gcc > STATIC = > SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread > -ldl > -XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm > +XLIBS = -lX11 -lm > INC = -I/usr/include/ > KEY = key > > — > Reply to this email directly, view it on GitHub > <#10 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AQVFPGZDOVNJ22IWAIZNB4DW7XDJDANCNFSM5Z42KRCA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMXGSYGCEOSBQPBPTVVWKTW7XK5FANCNFSM5Z42KRCA>. You are receiving this because you commented.Message ID: ***@***.***>

-- Peter Barada ***@***.***

[ryanpg123]

Fixed. Thank you!

…

On Wed, Apr 5, 2023 at 11:12 PM pbarada ***@***.***> wrote: Instead of previous patch, try this: diff --git a/mdep/linux/makefile b/mdep/linux/makefile index c734cd4..b028579 100644 --- a/mdep/linux/makefile +++ b/mdep/linux/makefile @@ -6,8 +6,8 @@ CC = gcc STATIC = -SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread -ldl -XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm +SOUNDLIBS = -lasound -lpthread -ldl +XLIBS = -lX11 -lm INC = -I/usr/include/ KEY = key which should remove all explicit path and libraries names needed to link keykit... On 4/5/23 16:47, Ryan wrote: > gcc -Wall -Wextra -O -I/usr/include/ -g yacc.o sym.o real.o code.o code2.o > main.o util.o mdep1.o mfin.o phrase.o misc.o fsm.o grid.o view.o midi.o > clock.o mdep2.o keyto.o regex.o task.o fifo.o kwind.o menu.o bltin.o > meth.o > -lX11 -lm /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ -lpthread > -ldl -o key > /usr/bin/ld: skipping incompatible /usr/lib//libX11.so when searching for > -lX11 > /usr/bin/ld: skipping incompatible /usr/lib//libm.so when searching > for -lm > /usr/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libasound.so.2: No such > file or directory > collect2: error: ld returned 1 exit status > make[1]: *** [makefile:93: key] Error 1 > make[1]: Leaving directory '/home/ryanpg/src/keykit/src' > make: *** [makefile:416: install_linux] Error 2 > > I think the correct directory is /usr/lib64/ > > "Reality is that which, when you stop believing in it, doesn’t go away." > -Philip K. Dick > > > On Wed, Apr 5, 2023 at 2:42 PM pbarada ***@***.***> wrote: > > > Grr, github doesn't look to handle email attached patches. Try following > > patch (that specifies "-lX11" instead of explicit path to libX11.so.6 > > shared library: > > > > diff --git a/mdep/linux/makefile b/mdep/linux/makefile > > index c734cd4..27d57bd 100644 > > --- a/mdep/linux/makefile > > +++ b/mdep/linux/makefile > > @@ -7,7 +7,7 @@ > > CC = gcc > > STATIC = > > SOUNDLIBS = /usr/lib/x86_64-linux-gnu/libasound.so.2 -L/usr/lib/ > -lpthread > > -ldl > > -XLIBS = /usr/lib/x86_64-linux-gnu/libX11.so.6 -lm > > +XLIBS = -lX11 -lm > > INC = -I/usr/include/ > > KEY = key > > > > — > > Reply to this email directly, view it on GitHub > > <#10 (comment) >, > > or unsubscribe > > > < https://github.com/notifications/unsubscribe-auth/AQVFPGZDOVNJ22IWAIZNB4DW7XDJDANCNFSM5Z42KRCA > > > . > > You are receiving this because you authored the thread.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > <#10 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABMXGSYGCEOSBQPBPTVVWKTW7XK5FANCNFSM5Z42KRCA >. > You are receiving this because you commented.Message ID: > ***@***.***> > -- Peter Barada ***@***.*** — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQVFPG6BKD7ZBBVTODEKJXDW7Y7DJANCNFSM5Z42KRCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>