test: fix build on 32bit platforms #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce with: $ GOARCH=386 go test -v github.com/notaryproject/notation-go ./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows) FAIL github.com/notaryproject/notation-go [build failed] FAIL Signed-off-by: Reinhard Tartler <[email protected]> Signed-off-by: Simon Josefsson <[email protected]>
jas4711
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Contributor
Author
|
Identical to #500 but with signature |
Contributor
Author
|
Btw, the |
Member
|
Thank you @jas4711 ! |
yizha1
approved these changes
Nov 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 81.47% 82.76% +1.29%
==========================================
Files 36 36
Lines 3358 2629 -729
==========================================
- Hits 2736 2176 -560
+ Misses 480 311 -169
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shizhMSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce with:
$ GOARCH=386 go test -v github.com/notaryproject/notation-go ./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)
FAIL github.com/notaryproject/notation-go [build failed]
FAIL