Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many incorrect or unmet peer dependency warning when installing #307

Closed
Tbaut opened this issue Aug 6, 2019 · 8 comments
Closed

Many incorrect or unmet peer dependency warning when installing #307

Tbaut opened this issue Aug 6, 2019 · 8 comments

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Aug 6, 2019

When running yarn:

warning " > [email protected]" has incorrect peer dependency "react-native@^0.50.4".
warning " > [email protected]" has incorrect peer dependency "react-native@^0.40.0".
warning "react-navigation > [email protected]" has unmet peer dependency "react-native-screens@^1.0.0 || ^1.0.0-alpha".
warning "react-navigation > [email protected]" has unmet peer dependency "react-native-screens@^1.0.0 || ^1.0.0-alpha".
warning "react-navigation > [email protected]" has unmet peer dependency "react-native-screens@^1.0.0 || ^1.0.0-alpha".
warning "@react-native-community/eslint-config > @typescript-eslint/[email protected]" has incorrect peer dependency "eslint@^5.0.0".
warning "@react-native-community/eslint-config > @typescript-eslint/[email protected]" has incorrect peer dependency "eslint@^5.0.0".
warning "@react-native-community/eslint-config > [email protected]" has incorrect peer dependency "eslint@^3.0.0 || ^4.0.0 || ^5.0.0".
warning "@react-native-community/eslint-config > [email protected]" has incorrect peer dependency "eslint@^3.17.0 || ^4 || ^5".
warning "@react-native-community/eslint-config > @typescript-eslint/eslint-plugin > @typescript-eslint/[email protected]" has unmet peer dependency "typescript@*".
warning "@react-native-community/eslint-config > @typescript-eslint/eslint-plugin > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev".
@Tbaut Tbaut added the F5-task label Aug 6, 2019
@Tbaut Tbaut added this to the v3.1 milestone Aug 6, 2019
@geastwood
Copy link
Contributor

  • react-native-markdown-renderer: in their package.json they have specified the peerDependencies inaccurate, a PR is submitted.

  • [email protected] specified also inaccurately, however, they have fixed in a newer release. Updating the lib will fix the problem.

  • Warnings regarding react-navigation is due to the fact, react-native-screens is defined as peerDependencies, however, is not mention in your package.json. But it will still work, since yarn will nevertheless install it under node_modules. In order to get rid of the warning, just specify in package.json

  • And with react-native-community, guess the only option is to wait for them to fix.

@geastwood
Copy link
Contributor

What does the tag F5-task mean?

@Tbaut
Copy link
Contributor Author

Tbaut commented Aug 11, 2019

Thanks for your help on that. The label F5-task helps defining this issue. It's not a feature, a bug fix or a refactor. I'd understand it as "chore".

@geastwood
Copy link
Contributor

I could put up a PR.

  • react-native-markdown-renderer: wait for the that PR to be merge
  • react-native-secure-storage: will update the lib to fix the warning
  • react-navigation: won't do anything, since it's a bit overkill to introduce a lib just to fix the warning
  • react-native-community: won't do anything

@Tbaut
Copy link
Contributor Author

Tbaut commented Aug 12, 2019

That would be awesome :)

react-native-secure-storage: will update the lib to fix the warning

This is currently hosted https://github.com/paritytech/react-native-secure-storage I don't know why it was forked and we should check if it's possible to use the originial one instead now.

@geastwood
Copy link
Contributor

Interesting, haven't realized it has been forked, thanks for the heads up! I will check the difference and put up a PR.

@geastwood
Copy link
Contributor

geastwood commented Aug 12, 2019

react-native-secure-store should be replaced with more robust/secure implementation. Also refer to this comment.

I think this Issue is almost meaningless since only to wait for the merge of react-native-markdown-renderer.

@Slesarew
Copy link
Contributor

RN removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants