prevent dir listing for more restricted deployment environment#25
Open
tsingakbar wants to merge 1 commit intonovnc:masterfrom
Open
prevent dir listing for more restricted deployment environment#25tsingakbar wants to merge 1 commit intonovnc:masterfrom
tsingakbar wants to merge 1 commit intonovnc:masterfrom
Conversation
Member
|
I'm afraid some user will want to be able to list files, so this would have to be an optional feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background
http.FileServerused by golang implemtation will list directory content when the request path is a directory.we deploy novnc for internal usage, but the deploy enviroment is equiped with lots of security restrictions, and dir-listing is not allowed for that.
The PR will
403 Forbiddendirectory listing http request.