Skip to content

[FEATURE] Allow non-ascii characters in noticies #37

Open
@sosoba

Description

@sosoba

What / Why

The server can add a header (npm-notice) containing the message for the npm-cli end user.
However, the implementation limits the alphabet to ascii.

It happens because http headers are 7bit ascii and application layer is responsible for encoding.

check-response.js

function checkResponse (method, res, registry, startTime, opts_ = {}) {
    // ...
    opts.log.notice('', res.headers.get('npm-notice'))

I want to propose to add agreed ascii to unicode decoder between headers.get and log.notice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions