Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
joaopedrodcf
left a comment
joaopedrodcf
left a comment
There was a problem hiding this comment.
Hope you guys don't mind me trying to review the PR 🙏
43081j
reviewed
Mar 30, 2026
43081j
reviewed
Mar 30, 2026
| try { | ||
| const replacement = await $fetch<ModuleReplacement | null>(`/api/replacements/${name}`) | ||
| const response = await $fetch<{ | ||
| mapping: ModuleReplacementMapping |
Contributor
There was a problem hiding this comment.
@danielroe iirc you said these types are inferred based on the route. is that true? does this not infer them because of the interpolation?
43081j
reviewed
Mar 30, 2026
43081j
reviewed
Mar 30, 2026
43081j
reviewed
Mar 30, 2026
ghostdevv
requested changes
Apr 5, 2026
43081j
approved these changes
Apr 7, 2026
ghostdevv
approved these changes
Apr 7, 2026
joaopedrodcf
approved these changes
Apr 7, 2026
Contributor
|
Are we deferring this till 0.9? |
Contributor
|
yes. it relies on me publishing module-replacements@3 too, which I haven't done yet. |
Contributor
Author
|
I'll also start on working adding replacements v3 to https://github.com/npmx-dev/vscode-npmx 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module replacements v3
Description
Update
module-replacementsto v3Update
Compare/ReplacementSuggestion.vue,Package/Replacement.vue,npm/useReplacementDependencies.ts,useCompareReplacements.ts,useModuleReplacement.ts,package/[[org]]/[name].vue,replacements/[...pkg].get.tsaccordinglyRemove
"MDN"from localesUpdate existing tests:
a11y.spec.ts,composables/use-replacement-dependencies.spec.ts,composables/use-compare-replacements.spec.tsAdd new test fixture
npm-registry/packuments/strip-ansi.jsonAdd new tests:
e2e/compare-replacements.spec.ts,e2e/package-replacements.spec.tsScreenshots
Simple
Native
Documented
Removal
Compare page