Skip to content

Commit f82bc5e

Browse files
committed
doc: review comment updates
review comment updates Signed-off-by: divya pillai <[email protected]>
1 parent 1f723c1 commit f82bc5e

File tree

10 files changed

+67
-52
lines changed

10 files changed

+67
-52
lines changed

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,14 @@ Modules communicate through [zbus](https://docs.nordicsemi.com/bundle/ncs-latest
2525

2626
> **Note**: If you're new to nRF91 series and cellular IoT, consider taking the [Nordic Developer Academy Cellular Fundamentals Course](https://academy.nordicsemi.com/courses/cellular-iot-fundamentals).
2727
28-
## Documentation
29-
30-
For official documentation for the Asset tracker template, see [documentation](https://docs.nordicsemi.com/bundle/asset-tracker-template-latest/page/index.html).
31-
3228
## Quick Start
3329

3430
For detailed setup instructions using the [nRF Connect for VS Code extension](https://docs.nordicsemi.com/bundle/nrf-connect-vscode/page/index.html) and advanced configuration options, see the [Getting Started Guide](docs/common/getting_started.md).
3531

3632
For pre-built binaries, refer to the latest tag and release artifacts documentaion; [release artifacts](docs/common/release.md).
3733

3834
> [!TIP]
39-
> Use the [Download nRF Connect for Desktop Quick Start application](https://www.nordicsemi.com/Products/Development-tools/nrf-connect-for-desktop/download#infotabs) for a guided setup and provisioning process.
35+
> Download and run the [Quick Start app](https://docs.nordicsemi.com/bundle/nrf-connect-quickstart/page/index.html) in the [nRF Connect for Desktop](https://www.nordicsemi.com/Software-and-Tools/Development-Tools/nRF-Connect-for-desktop)`_ for a guided setup and provisioning process.
4036
4137
### Prerequisites
4238

docs/common/customization.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ To add a new zbus event, complete the following procedure:
3333
};
3434
```
3535

36-
2. Implement publishing of VBUS connected and disconnected events by modifying the existing `event_callback()` function in `power.c`:
36+
1. Implement publishing of VBUS connected and disconnected events by modifying the existing `event_callback()` function in `power.c`:
3737
```c
3838
if (pins & BIT(NPM13XX_EVENT_VBUS_DETECTED)) {
3939
LOG_DBG("VBUS detected");
@@ -70,7 +70,7 @@ To add a new zbus event, complete the following procedure:
7070
}
7171
```
7272

73-
3. Make sure the channel is included in the subscriber module (for example, `main.c`). Add the channel to the channel list:
73+
1. Make sure the channel is included in the subscriber module (for example, `main.c`). Add the channel to the channel list:
7474

7575
```c
7676
# define CHANNEL_LIST(X) \
@@ -84,7 +84,7 @@ To add a new zbus event, complete the following procedure:
8484
X(POWER_CHAN, struct power_msg) \
8585
```
8686

87-
4. Implement a handler for the new events in the subscriber module (for example, in the main module's state machine in `running_run`):
87+
1. Implement a handler for the new events in the subscriber module (for example, in the main module's state machine in `running_run`):
8888

8989
```c
9090
if (state_object->chan == &POWER_CHAN) {
@@ -136,7 +136,7 @@ To add a new zbus event, complete the following procedure:
136136
}
137137
```
138138

139-
5. Test the implementation by connecting and disconnecting VBUS to verify the LED patterns change as expected.
139+
1. Test the implementation by connecting and disconnecting VBUS to verify the LED patterns change as expected.
140140

141141
## Add environmental sensor
142142

@@ -171,7 +171,7 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
171171
};
172172
```
173173

174-
2. Update the environmental module's state structure to include the magnetometer device reference and data storage:
174+
1. Update the environmental module's state structure to include the magnetometer device reference and data storage:
175175

176176
```c
177177
struct environmental_state_object {
@@ -187,7 +187,7 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
187187
};
188188
```
189189

190-
3. Initialize the device reference using the devicetree label:
190+
1. Initialize the device reference using the devicetree label:
191191

192192
```c
193193
struct environmental_state_object environmental_state = {
@@ -196,7 +196,7 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
196196
};
197197
```
198198

199-
4. Update the sensor sampling function signature to include the magnetometer device:
199+
1. Update the sensor sampling function signature to include the magnetometer device:
200200

201201
```c
202202
static void sample_sensors(const struct device *const bme680, const struct device *const bmm350)
@@ -208,7 +208,7 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
208208
sample_sensors(state_object->bme680, state_object->bmm350);
209209
```
210210

211-
5. Implement sensor data acquisition using the Zephyr Sensor API:
211+
1. Implement sensor data acquisition using the Zephyr Sensor API:
212212

213213
```c
214214
err = sensor_sample_fetch(bmm350);
@@ -241,7 +241,7 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
241241
};
242242
```
243243

244-
6. Update the `environmental_msg` structure in `environmental.h` to include the magnetic field data:
244+
1. Update the `environmental_msg` structure in `environmental.h` to include the magnetic field data:
245245

246246
```c
247247
struct environmental_msg {
@@ -254,9 +254,9 @@ Thingy:91 X is used as an example, as it is a supported board in the template wi
254254
};
255255
```
256256

257-
The magnetometer data is now part of the environmental message and will be automatically handled by the storage module through the existing `ENVIRONMENTAL` data type. No changes to `storage_data_types.h` or `storage_data_types.c` are needed since the existing `environmental_check()` and `environmental_extract()` functions will handle the entire structure including the magnetic field data.
257+
The magnetometer data is now part of the environmental message and will be automatically handled by the storage module through the existing `ENVIRONMENTAL` data type. No changes to `storage_data_types.h` or `storage_data_types.c` are needed since the existing `environmental_check()` and `environmental_extract()` functions will handle the entire structure, including the magnetic field data.
258258

259-
7. Add cloud integration in the `send_storage_data_to_cloud()` function in `cloud.c` to send magnetometer data to nRF Cloud. Add this code after the existing environmental sensor data handling:
259+
1. Add cloud integration in the `send_storage_data_to_cloud()` function in `cloud.c` to send magnetometer data to nRF Cloud. Add this code after the existing environmental sensor data handling:
260260

261261
```c
262262
#if defined(CONFIG_APP_ENVIRONMENTAL)
@@ -316,14 +316,14 @@ To add your own module, complete the following steps:
316316
mkdir -p app/src/modules/dummy
317317
```
318318

319-
2. Create the following files in the module directory:
319+
1. Create the following files in the module directory:
320320

321321
- `dummy.h` - Module interface definitions.
322322
- `dummy.c` - Module implementation.
323323
- `Kconfig.dummy` - Module configuration options.
324324
- `CMakeLists.txt` - Build system configuration.
325325

326-
3. In `dummy.h`, define the module's interface:
326+
1. In `dummy.h`, define the module's interface:
327327
328328
```c
329329
#ifndef _DUMMY_H_
@@ -363,7 +363,7 @@ To add your own module, complete the following steps:
363363
#endif /* _DUMMY_H_ */
364364
```
365365

366-
4. In `dummy.c`, implement the module's functionality:
366+
1. In `dummy.c`, implement the module's functionality:
367367

368368
```c
369369
#include <zephyr/kernel.h>
@@ -521,7 +521,7 @@ To add your own module, complete the following steps:
521521
K_LOWEST_APPLICATION_THREAD_PRIO, 0, 0);
522522
```
523523

524-
5. In `Kconfig.dummy`, define module configuration options:
524+
1. In `Kconfig.dummy`, define module configuration options:
525525

526526
```kconfig
527527
menuconfig APP_DUMMY
@@ -557,20 +557,20 @@ To add your own module, complete the following steps:
557557
endif # APP_DUMMY
558558
```
559559
560-
6. In `CMakeLists.txt`, configure the build system to include the source files of the module:
560+
1. In `CMakeLists.txt`, configure the build system to include the source files of the module:
561561
562562
```cmake
563563
target_sources(app PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/dummy.c)
564564
target_include_directories(app PRIVATE .)
565565
```
566566
567-
7. Add the module to the main application's CMakeLists.txt:
567+
1. Add the module to the main application's CMakeLists.txt:
568568
569569
```cmake
570570
add_subdirectory(src/modules/dummy)
571571
```
572572
573-
8. Increase `CONFIG_TASK_WDT_CHANNELS` in the `prj.conf` file to accommadate for the new module's task watchdog integration.
573+
1. Increase the value of the `CONFIG_TASK_WDT_CHANNELS` Kconfig option in the `prj.conf` file to accommadate for the new module's task watchdog integration.
574574
575575
The dummy module is now ready to use. It provides the following functionality:
576576

docs/common/getting_started.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Getting Started
1+
# Getting started
22

33
To get started with Asset tracker template, you need to set up the development environment, build the application, and run it on supported hardware.
44
You can use any of the following tools, depending on your preferred development environment:
@@ -31,7 +31,7 @@ For pre-built binaries, refer to the latest tag and the [release artifacts](rele
3131

3232
* **nRF Connect SDK toolchain v3.0.0 or later**
3333

34-
- Follow the instructions in the [sdk-manager command](https://docs.nordicsemi.com/bundle/nrfutil/page/nrfutil-sdk-manager/nrfutil-sdk-manager.html) documentation to install v3.1.0 of the nRF Connect SDK toolchain.
34+
- Follow the instructions in the [sdk-manager command](https://docs.nordicsemi.com/bundle/nrfutil/page/nrfutil-sdk-manager/nrfutil-sdk-manager.html) documentation to install v3.0.0 of the nRF Connect SDK toolchain.
3535

3636
## Supported boards
3737

@@ -50,13 +50,13 @@ The Asset Tracker Template is continuously verified in CI on the following board
5050
Before initializing, start the toolchain environment:
5151

5252
```shell
53-
nrfutil sdk-manager toolchain launch --ncs-version v3.1.0 --shell
53+
nrfutil sdk-manager toolchain launch --ncs-version v3.0.0 --shell
5454
```
5555

56-
Alternatively, you can run the command with a specific nRF Connect SDK version. For example, if you are using v3.1.0, run:
56+
Alternatively, you can run the command with a specific nRF Connect SDK version. For example, if you are using version 3.0.1, run:
5757

5858
```shell
59-
nrfutil sdk-manager toolchain launch --ncs-version v3.1.0 -- <your command>
59+
nrfutil sdk-manager toolchain launch --ncs-version v3.0.0 -- <your command>
6060
```
6161

6262
To run for instance the `west` command with the specified version of toolchain. You can create an alias or shell function for this command to avoid typing it in full every time.
@@ -128,7 +128,7 @@ west build -p -b thingy91x/nrf9151/ns -- -DEXTRA_CONF_FILE="overlay-memfault.con
128128

129129
To connect to [nRF Cloud](https://nrfcloud.com), the device must be provisioned to your account. You can provision the device using one of the following methods:
130130

131-
* **Quickstart application**: Use the [Download nRF Connect for Desktop](https://www.nordicsemi.com/Products/Development-tools/nrf-connect-for-desktop/download#infotabs) Quick Start application for a streamlined setup process.
131+
* **Quickstart application**: Use the [Quick Start app](https://docs.nordicsemi.com/bundle/nrf-connect-quickstart/page/index.html) in the [nRF Connect for Desktop](https://www.nordicsemi.com/Software-and-Tools/Development-Tools/nRF-Connect-for-desktop)`_ for a streamlined setup process.
132132
* **Manual provisioning**: Follow the detailed steps in the [Provisioning](provisioning.md) documentation.
133133
134134
The provisioning process establishes the necessary credentials and certificates for secure communication between your device and nRF Cloud.
@@ -155,7 +155,7 @@ To test that everything is working as expected, you can do the following:
155155
156156
```shell
157157
158-
*** Booting nRF Connect SDK v3.1.0-3bfc46578e42 ***
158+
*** Booting nRF Connect SDK v3.0.0-3bfc46578e42 ***
159159
*** Using Zephyr OS v4.0.99-a0e545cb437a ***
160160
Attempting to boot slot 0.
161161
Attempting to boot from address 0x8200.
@@ -174,7 +174,7 @@ To test that everything is working as expected, you can do the following:
174174
[00:00:00.257,324] <inf> spi_nor: GD25LE255E@0: 32 MiBy flash
175175
[00:00:00.311,828] <inf> wifi_nrf_bus: SPIM spi@b000: freq = 8 MHz
176176
[00:00:00.311,889] <inf> wifi_nrf_bus: SPIM spi@b000: latency = 0
177-
]mJ*** Using nRF Connect SDK v3.1.0-3bfc46578e42 ***
177+
]mJ*** Using nRF Connect SDK v3.0.0-3bfc46578e42 ***
178178
*** Using Zephyr OS v4.0.99-a0e545cb437a ***
179179
[00:00:00.520,202] <dbg> main: main: Main has started
180180
[00:00:00.520,263] <dbg> main: running_entry: running_entry

docs/common/location_services.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Location Services
1+
# Location services
22

33
The Asset Tracker uses [nRF Cloud's location services](https://docs.nordicsemi.com/bundle/nrf-cloud/page/LocationServices/LSOverview.html) to provide accurate device positioning through multiple methods. This document explains the available location services and their capabilities.
44

docs/common/provisioning.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ To update device credentials:
5252

5353
### Manual
5454

55-
1. Log in to the In [nRF Cloud](https://nrfcloud.com/#/) portal.
55+
1. Log in to the [nRF Cloud](https://nrfcloud.com/#/) portal.
5656
1. Select **Security Services** in the left sidebar.
5757

5858
A panel opens to the right.

docs/common/release.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,61 @@
1-
# Release Artifacts
1+
# Release artifacts
22

33
This document provides a comprehensive overview of all firmware deliverables and artifacts generated by the Asset Tracker Template.
44
Each firmware variant is optimized for specific use cases and hardware platforms.
55

6-
## Firmware Deliverables
6+
## Firmware deliverables
77

88
The Asset Tracker Template generates multiple firmware artifacts for different hardware platforms and configurations. Each artifact is built to serve specific development, testing, or production needs.
99

10-
### Primary Release Artifacts
10+
### Primary release artifacts
1111

12-
#### Standard Firmware Variants
12+
#### Standard firmware variants
1313

14-
| **Artifact Name** | **Hardware Platform** | **Description** | **Use Case** |
14+
| **Artifact name** | **Hardware platform** | **Description** | **Use case** |
1515
|-------------------|----------------------|----------------|--------------|
1616
| `att-thingy91x-{VERSION}.hex` | Thingy:91 X (nRF9151) | Standard production firmware with all core features enabled | Production deployment on Thingy:91 X devices |
1717
| `att-thingy91-{VERSION}.hex` | Thingy:91 (nRF9160) | Legacy production firmware for older Thingy:91 devices | Production deployment on original Thingy:91 devices |
1818
| `att-nrf9151dk-{VERSION}.hex` | nRF9151 DK | Development kit firmware with full feature set | Development and testing on nRF9151 DK |
1919
| `att-nrf9160dk-{VERSION}.hex` | nRF9160 DK | Development kit firmware for nRF9160-based boards | Development and testing on nRF9160 DK |
2020
| `att-nrf9161dk-{VERSION}.hex` | nRF9161 DK | Development kit firmware for nRF9161-based boards | Development and testing on nRF9161 DK |
2121

22-
#### Debug and Development Variants
22+
#### Debug and development variants
2323

24-
| **Artifact Name** | **Hardware Platform** | **Description** | **Use Case** |
24+
| **Artifact name** | **Hardware platform** | **Description** | **Use case** |
2525
|-------------------|----------------------|----------------|--------------|
2626
| `att-thingy91x-{VERSION}-debug.hex` | Thingy:91 X (nRF9151) | Debug build with enhanced logging and diagnostic features. **Note: This build uploads diagnostic and crash data to Memfault using Nordic's account and is intended for internal use only.** | Development debugging and issue investigation |
2727
| `att-thingy91x-{VERSION}-mqtt.hex` | Thingy:91 X (nRF9151) | Firmware with MQTT cloud connectivity instead of CoAP | Testing MQTT-based cloud communication |
2828

29-
#### Specialized Configuration Variants
29+
#### Specialized configuration variants
3030

31-
| **Artifact Name** | **Hardware Platform** | **Description** | **Use Case** |
31+
| **Artifact name** | **Hardware platform** | **Description** | **Use case** |
3232
|-------------------|----------------------|----------------|--------------|
3333
| `att-thingy91x-{VERSION}-mtrace.hex` | Thingy:91 X (nRF9151) | Firmware with modem trace output enabled through UART 1 | Cellular connectivity debugging and analysis |
3434
| `att-nrf9151dk-{VERSION}-mtrace.hex` | nRF9151 DK | Firmware with modem trace output enabled through UART 1 | Cellular connectivity debugging and analysis |
3535
| `att-nrf9161dk-{VERSION}-mtrace.hex` | nRF9161 DK | Firmware with modem trace output enabled through UART 1 | Cellular connectivity debugging and analysis |
3636
| `att-nrf9151dk-{VERSION}-ext-gnss.hex` | nRF9151 DK | Firmware configured for external GNSS antenna | Testing with external GNSS antenna setup |
3737

38-
### Configuration Overlays
38+
### Configuration overlays
3939

4040
The firmware variants are built using different configuration overlays that modify the base functionality:
4141

42-
| **Overlay File** | **Purpose** | **Key Features** |
42+
| **Overlay file** | **Purpose** | **Key features** |
4343
|------------------|-------------|------------------|
4444
| `overlay-etb.conf` | Embedded Trace Buffer (ETB) support | Hardware-level debugging and trace collection |
4545
| `overlay-memfault.conf` | Memfault integration | Crash reporting and device monitoring |
4646
| `overlay-storage-minimal.conf` | Minimal storage configuration | Reduced memory footprint with passthrough-only storage |
4747
| `overlay-upload-modem-traces-to-memfault.conf` | Modem trace to Memfault | Automatic upload of modem traces for analysis |
4848

49-
### Hardware Platform Support
49+
### Hardware platform support
5050

51-
#### Thingy:91 X (Primary Platform)
51+
#### Thingy:91 X (Primary platform)
5252

5353
- **SoC**: nRF9151
5454
- **Features**: Full sensor suite, battery operation, compact form factor
5555
- **Target Use**: Production IoT deployments, prototyping
5656
- **Memory Reports**: ROM and RAM usage reports generated for optimization
5757

58-
#### Development Kits
58+
#### Development kits
5959

6060
- **nRF9151 DK**: Primary development platform for nRF9151-based projects
6161
- **nRF9160 DK**: Legacy development support for nRF9160-based projects

docs/common/test_and_ci_setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Testing and CI Setup
1+
# Testing and CI setup
22

33
The Asset Tracker Template features a comprehensive testing infrastructure with tests run both on real hardware (on target) and emulation.
44
Code analysis is performed through compliance checks and SonarCloud analysis.

docs/common/tooling_troubleshooting.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,22 @@ For more knowledge on debugging and troubleshooting [nRF Connect SDK](https://gi
88
- [nRF Connect SDK Debugging Guide](https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/test_and_optimize/debugging.html)
99
- [Zephyr Debugging Guide](https://docs.zephyrproject.org/latest/develop/debug/index.html)
1010

11+
## Tools for debugging and troubleshooting
12+
13+
You can use the following tools for debugging and troubleshooting for the Asset Tracker Template:
14+
15+
- [Shell Commands](#shell-commands)
16+
- [Debugging Tools](#debugging-tools)
17+
18+
- [Low Power Profiling](#low-power-profiling)
19+
- [GDB Debugging](#gdb-debugging)
20+
- [SEGGER SystemView](#segger-systemview)
21+
- [Thread Analysis](#thread-analysis)
22+
- [Hardfaults](#hardfaults)
23+
24+
- [Memfault Remote Debugging](#memfault-remote-debugging)
25+
- [Modem Tracing](#modem-tracing)
26+
1127
## Shell Commands
1228

1329
The template provides several shell commands for controlling and monitoring device behavior. Connect to the device's UART interface using either:

docs/index.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ For detailed setup instructions using the [nRF Connect for VS Code extension](ht
3131

3232
For pre-built binaries, refer to the latest tag and release artifacts documentation; [release artifacts](docs/common/release.md).
3333

34+
> [!TIP]
35+
> Download and run the [Quick Start app](https://docs.nordicsemi.com/bundle/nrf-connect-quickstart/page/index.html) in the [nRF Connect for Desktop](https://www.nordicsemi.com/Software-and-Tools/Development-Tools/nRF-Connect-for-desktop)`_ for a guided setup and provisioning process.
36+
3437
### Prerequisites
3538

3639
* nRF Connect SDK development environment ([setup guide](https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/installation.html))

0 commit comments

Comments
 (0)