Skip to content

Commit 26489d1

Browse files
authored
fix(graph): ensure deps from graph-client->migrate-ui exists so taliwind styles are compiled correctly (#30762)
This PR removes the `// nx-ignore-next-line` from graph client to the migrate lib import. Without the dep being there, the tailwind styles will not include classes used by migrate UI. <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Styles are broken for migrate UI ## Expected Behavior Styles should work ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent b67fa37 commit 26489d1

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

graph/client/src/app/console-migrate/migrate.app.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import type { MigrationDetailsWithId } from 'nx/src/config/misc-interfaces';
44
// nx-ignore-next-line
55
import { type FileChange } from 'nx/src/devkit-exports';
6-
// nx-ignore-next-line
76
import { MigrateUI } from '@nx/graph-migrate';
87
/* eslint-enable @nx/enforce-module-boundaries */
98

graph/migrate/src/lib/components/automatic-migration.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable @nx/enforce-module-boundaries */
2-
import { FileChange } from '@nx/devkit';
2+
import { FileChange } from 'nx/src/devkit-exports';
33
import type { MigrationDetailsWithId } from 'nx/src/config/misc-interfaces';
44
import type { MigrationsJsonMetadata } from 'nx/src/command-line/migrate/migrate-ui-api';
55
/* eslint-enable @nx/enforce-module-boundaries */

graph/migrate/src/lib/components/migration-list.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable @nx/enforce-module-boundaries */
2-
import { FileChange } from '@nx/devkit';
2+
import { FileChange } from 'nx/src/devkit-exports';
33
import { MigrationsJsonMetadata } from 'nx/src/command-line/migrate/migrate-ui-api';
44
import type { MigrationDetailsWithId } from 'nx/src/config/misc-interfaces';
55
/* eslint-enable @nx/enforce-module-boundaries */

graph/migrate/src/lib/components/migration-timeline.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable @nx/enforce-module-boundaries */
2-
import { FileChange } from '@nx/devkit';
2+
import { FileChange } from 'nx/src/devkit-exports';
33
import type { MigrationDetailsWithId } from 'nx/src/config/misc-interfaces';
44
import type { MigrationsJsonMetadata } from 'nx/src/command-line/migrate/migrate-ui-api';
55

0 commit comments

Comments
 (0)