chore(misc): configure unit tests correctly for workspace

chore(core): update test setup for devkit

chore(js): fix unit test setup

chore(bundling): update unit test set up

chore(misc): fix export conditions and unit test setups

chore(misc): update unit test setup for testing tools

chore(misc): setup unit test config

chore(misc): update unit test setup

chore(misc): update test config for node

chore(misc): update react adjacent packages unit test setup

chore(misc): update angular to use new unit test setup

chore(misc): update unit test setup for nx

chore(misc): cleanup

Author: Coly010

docs/local-dist-migration-plan.md

@@ -0,0 +1,43 @@
+const NodeEnvironment = require('jest-environment-node').default;
+
+/**
+ * Custom Jest environment that patches Object.defineProperty to allow
+ * reconfiguration of spied properties.
+ *
+ * This is necessary because TypeScript project references change how modules
+ * are resolved, causing Jest spies to fail with "Cannot redefine property" errors.
+ */
+class CustomEnvironment extends NodeEnvironment {
+  constructor(config, context) {
+    super(config, context);
+  }
+
+  async setup() {
+    await super.setup();
+
+    // Patch Object.defineProperty to allow reconfiguration of spied properties
+    const originalDefineProperty = Object.defineProperty;
+    this.global.Object.defineProperty = function (obj, prop, descriptor) {
+      if (descriptor && typeof descriptor.configurable === 'undefined') {
+        descriptor.configurable = true;
+      }
+      try {
+        return originalDefineProperty(obj, prop, descriptor);
+      } catch (e) {
+        // If we can't redefine, try to delete and define
+        if (e.message && e.message.includes('Cannot redefine property')) {
+          try {
+            delete obj[prop];
+            return originalDefineProperty(obj, prop, descriptor);
+          } catch {
+            // If that also fails, just return the object
+            return obj;
+          }
+        }
+        throw e;
+      }
+    };
+  }
+}
+
+module.exports = CustomEnvironment;

jest-environment.js

@@ -12,6 +12,6 @@ module.exports = {
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageReporters: ['html'],
   maxWorkers: 1,
-  testEnvironment: 'node',
+  testEnvironment: require.resolve('./jest-environment.js'),
   setupFiles: ['../../scripts/unit-test-setup.js'],
 };

jest.preset.js

@@ -36,9 +36,9 @@
       "default": "./dist/index.js"
     },
     "./src/models/style-preprocessor-options": {
-      "import": "./dist/models/style-preprocessor-options.js",
       "types": "./dist/models/style-preprocessor-options.d.ts",
-      "@nx/nx-source": "./src/models/style-preprocessor-options.ts"
+      "@nx/nx-source": "./src/models/style-preprocessor-options.ts",
+      "import": "./dist/models/style-preprocessor-options.js"
     }
   },
   "dependencies": {

packages/angular-rspack-compiler/package.json

@@ -0,0 +1,8 @@
+// Mock for @rspack/core to avoid loading native bindings during tests
+module.exports = {
+  NormalModuleReplacementPlugin: jest.fn(),
+  rspack: jest.fn(),
+  Configuration: jest.fn(),
+  Compiler: jest.fn(),
+  Stats: jest.fn(),
+};

packages/angular/__mocks__/@rspack-core.js

@@ -1,5 +1,5 @@
-import path = require('path');
-import json = require('./migrations.json');
+import path from 'path';
+import json from './migrations.json';
 
 import { assertValidMigrationPaths } from '@nx/devkit/internal-testing-utils';
 

packages/angular/jest.config.cts renamed to packages/angular/jest.config.ts

@@ -22,65 +22,76 @@
     "./generators.json": "./generators.json",
     "./executors.json": "./executors.json",
     "./generators": {
-      "import": "./dist/generators.js",
       "types": "./generators.d.ts",
-      "@nx/nx-source": "./generators.ts"
+      "@nx/nx-source": "./generators.ts",
+      "import": "./dist/generators.js",
+      "default": "./dist/generators.js"
     },
     "./executors": {
-      "import": "./dist/executors.js",
       "types": "./executors.d.ts",
-      "@nx/nx-source": "./executors.ts"
+      "@nx/nx-source": "./executors.ts",
+      "import": "./dist/executors.js",
+      "default": "./dist/executors.js"
     },
     "./plugin": {
-      "import": "./dist/plugin.js",
       "types": "./plugin.d.ts",
-      "@nx/nx-source": "./plugin.ts"
+      "@nx/nx-source": "./plugin.ts",
+      "import": "./dist/plugin.js",
+      "default": "./dist/plugin.js"
     },
     "./tailwind": {
-      "import": "./dist/tailwind.js",
       "types": "./tailwind.d.ts",
-      "@nx/nx-source": "./tailwind.ts"
+      "@nx/nx-source": "./tailwind.ts",
+      "import": "./dist/tailwind.js",
+      "default": "./dist/tailwind.js"
     },
     "./module-federation": {
-      "import": "./dist/module-federation/index.js",
       "types": "./module-federation/index.d.ts",
-      "@nx/nx-source": "./module-federation/index.ts"
+      "@nx/nx-source": "./module-federation/index.ts",
+      "import": "./dist/module-federation/index.js",
+      "default": "./dist/module-federation/index.js"
     },
     "./src/utils": {
-      "import": "./dist/src/utils/index.js",
       "types": "./src/utils/index.d.ts",
-      "@nx/nx-source": "./src/utils/index.ts"
+      "@nx/nx-source": "./src/utils/index.ts",
+      "import": "./dist/src/utils/index.js",
+      "default": "./dist/src/utils/index.js"
     },
     "./plugins/component-testing": {
-      "import": "./dist/plugins/component-testing.js",
       "types": "./plugins/component-testing.d.ts",
-      "@nx/nx-source": "./plugins/component-testing.ts"
+      "@nx/nx-source": "./plugins/component-testing.ts",
+      "import": "./dist/plugins/component-testing.js",
+      "default": "./dist/plugins/component-testing.js"
     },
     "./src/generators/utils": {
-      "import": "./dist/src/generators/utils/index.js",
       "types": "./src/generators/utils/index.d.ts",
-      "@nx/nx-source": "./src/generators/utils/index.ts"
+      "@nx/nx-source": "./src/generators/utils/index.ts",
+      "import": "./dist/src/generators/utils/index.js",
+      "default": "./dist/src/generators/utils/index.js"
     },
     "./src/generators/move/move-impl": {
-      "import": "./dist/src/generators/move/move-impl.js",
       "types": "./src/generators/move/move-impl.d.ts",
-      "@nx/nx-source": "./src/generators/move/move-impl.ts"
+      "@nx/nx-source": "./src/generators/move/move-impl.ts",
+      "import": "./dist/src/generators/move/move-impl.js",
+      "default": "./dist/src/generators/move/move-impl.js"
     },
     "./src/builders/*/schema.json": "./dist/src/builders/*/schema.json",
     "./src/builders/*.impl": {
-      "import": "./dist/src/builders/*.impl.js",
       "types": "./src/builders/*.impl.d.ts",
-      "@nx/nx-source": "./src/builders/*.impl.ts"
+      "@nx/nx-source": "./src/builders/*.impl.ts",
+      "import": "./dist/src/builders/*.impl.js",
+      "default": "./dist/src/builders/*.impl.js"
     },
     "./src/builders/*/schema": {
       "types": "./src/builders/*/schema.d.ts",
       "@nx/nx-source": "./src/builders/*/schema.ts"
     },
     "./src/executors/*/schema.json": "./dist/src/executors/*/schema.json",
     "./src/executors/*.impl": {
-      "import": "./dist/src/executors/*.impl.js",
       "types": "./src/executors/*.impl.d.ts",
-      "@nx/nx-source": "./src/executors/*.impl.ts"
+      "@nx/nx-source": "./src/executors/*.impl.ts",
+      "import": "./dist/src/executors/*.impl.js",
+      "default": "./dist/src/executors/*.impl.js"
     },
     "./src/executors/*/schema": {
       "types": "./src/executors/*/schema.d.ts",

packages/angular/migrations.spec.ts

@@ -1,6 +1,28 @@
+// need to mock cypress otherwise it'll use installed version in this repo's package.json
+jest.mock('@nx/cypress/src/utils/versions', () => ({
+  ...jest.requireActual('@nx/cypress/src/utils/versions'),
+  getInstalledCypressMajorVersion: jest.fn(),
+}));
+jest.mock('enquirer');
+let mockFormatFiles = jest
+  .fn()
+  .mockImplementation(jest.requireActual('@nx/devkit').formatFiles);
+jest.mock('@nx/devkit', () => {
+  const original = jest.requireActual('@nx/devkit');
+  return {
+    ...original,
+    ensurePackage: (pkg: string) => jest.requireActual(pkg),
+    createProjectGraphAsync: jest.fn().mockResolvedValue({
+      nodes: {},
+      dependencies: {},
+    }),
+    formatFiles: mockFormatFiles,
+  };
+});
+
 import { getInstalledCypressMajorVersion } from '@nx/cypress/src/utils/versions';
-import * as devkit from '@nx/devkit';
 import {
+  getProjects,
   NxJsonConfiguration,
   parseJson,
   readJson,
@@ -24,24 +46,6 @@ import {
 import { generateTestApplication } from '../utils/testing';
 import type { Schema } from './schema';
 
-// need to mock cypress otherwise it'll use installed version in this repo's package.json
-jest.mock('@nx/cypress/src/utils/versions', () => ({
-  ...jest.requireActual('@nx/cypress/src/utils/versions'),
-  getInstalledCypressMajorVersion: jest.fn(),
-}));
-jest.mock('enquirer');
-jest.mock('@nx/devkit', () => {
-  const original = jest.requireActual('@nx/devkit');
-  return {
-    ...original,
-    ensurePackage: (pkg: string) => jest.requireActual(pkg),
-    createProjectGraphAsync: jest.fn().mockResolvedValue({
-      nodes: {},
-      dependencies: {},
-    }),
-  };
-});
-
 describe('app', () => {
   let appTree: Tree;
   let mockedInstalledCypressVersion: jest.Mock<
@@ -170,7 +174,7 @@ describe('app', () => {
       await generateApp(appTree, 'my-app', { tags: 'one,two,my-app' });
 
       // ASSERT
-      const projects = devkit.getProjects(appTree);
+      const projects = getProjects(appTree);
       expect(projects).toEqual(
         new Map(
           Object.entries({
@@ -287,7 +291,7 @@ describe('app', () => {
       // ARRANGE
       const nxJson = readNxJson(appTree);
       nxJson.defaultProject = 'some-awesome-project';
-      devkit.updateNxJson(appTree, nxJson);
+      updateNxJson(appTree, nxJson);
 
       // ACT
       await generateApp(appTree);
@@ -309,7 +313,7 @@ describe('app', () => {
       await generateApp(appTree, 'my-dir/my-app', {
         tags: 'one,two,my-app',
       });
-      const projects = devkit.getProjects(appTree);
+      const projects = getProjects(appTree);
       expect(projects).toEqual(
         new Map(
           Object.entries({
@@ -584,11 +588,9 @@ describe('app', () => {
 
   describe('format files', () => {
     it('should format files', async () => {
-      const formatFilesSpy = jest.spyOn(devkit, 'formatFiles');
-
       await generateApp(appTree, 'my-app', { skipFormat: false });
 
-      expect(formatFilesSpy).toHaveBeenCalled();
+      expect(mockFormatFiles).toHaveBeenCalled();
       expect(
         appTree.read('my-app/src/app/app-module.ts', 'utf-8')
       ).toMatchSnapshot();

packages/angular/package.json

@@ -1,6 +1,17 @@
-import 'nx/src/internal-testing-utils/mock-project-graph';
+let mockFormatFiles = jest
+  .fn()
+  .mockImplementation(jest.requireActual('@nx/devkit').formatFiles);
+jest.mock('@nx/devkit', () => ({
+  ...jest.requireActual('@nx/devkit'),
+  formatFiles: mockFormatFiles,
+  createProjectGraphAsync: jest.fn().mockImplementation(async () => {
+    return {
+      nodes: {},
+      dependencies: {},
+    };
+  }),
+}));
 
-import * as devkit from '@nx/devkit';
 import {
   addProjectConfiguration,
   readJson,
@@ -228,7 +239,6 @@ describe('librarySecondaryEntryPoint generator', () => {
   });
 
   it('should format files', async () => {
-    jest.spyOn(devkit, 'formatFiles');
     addProjectConfiguration(tree, 'lib1', {
       root: 'libs/lib1',
       projectType: 'library',
@@ -243,7 +253,7 @@ describe('librarySecondaryEntryPoint generator', () => {
       library: 'lib1',
     });
 
-    expect(devkit.formatFiles).toHaveBeenCalled();
+    expect(mockFormatFiles).toHaveBeenCalled();
     expect(
       tree.read('libs/lib1/testing/src/index.ts', 'utf-8')
     ).toMatchSnapshot();